Sorry about that; yes it was tested. Tested-by: Samuel Greenfeld <<a href="mailto:greenfeld@laptop.org">greenfeld@laptop.org</a>> <div class="gmail_quote">On Thu, Apr 28, 2011 at 10:58 AM, Simon Schampijer <<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On 04/15/2011 06:47 PM, Sascha Silbe wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Excerpts from Simon Schampijer's message of Thu Apr 14 19:42:05 +0200 2011: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> We only approve channels in the shell and do not claim to handle them anymore. The handling is now done by the activity (toolkit patch). More info about approving and handling of channels can be found at [1]. </blockquote> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> This patch does as well only handle sugar activity invitations, invitations from non-sugar clients will be handled in a separate patch. </blockquote> s/as well // ? </blockquote> </div> Yes.<div class="im"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> [src/jarabe/model/telepathyclient.py] <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> @@ -60,8 +62,17 @@ class TelepathyClient(dbus.service.Object, DBusProperties): def __get_filters_cb(self): logging.debug('__get_filters_cb') - filter_dict = dbus.Dictionary({}, signature='sv') - return dbus.Array([filter_dict], signature='a{sv}') + + filt = { + CHANNEL + '.ChannelType': CHANNEL_TYPE_TEXT, + CHANNEL + '.TargetHandleType': CONNECTION_HANDLE_TYPE_ROOM, + } + filter_dict = dbus.Dictionary(filt, signature='sv') + filters = dbus.Array([filter_dict], signature='a{sv}') + + logging.debug('__get_filters_cb %r', filters) + + return filters </blockquote> Given that "filt" is non-empty, do we really need the explicit conversions? I.e. would the following work? def __get_filters_cb(self): logging.debug('__get_filters_cb') return [{ CHANNEL + '.ChannelType': CHANNEL_TYPE_TEXT, CHANNEL + '.TargetHandleType': CONNECTION_HANDLE_TYPE_ROOM, }] (The content seems to be static, so it wouldn't make sense to log it.) </blockquote> </div> Ok, the logging can go away.<div class="im"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> The general approach looks fine. With or without the above changes, but after you got Samuels Tested-By: </blockquote> </div> Sam, did you test this already? Regards, Simon </blockquote></div>