I was reading your patches.<br>I think you must send the patches to sugar-devel list for proper review.<br>There are patches who can be consolidated to be more clear like in Typing Turtle, or in StopWatch. <br>In the Distance activity, the Atmosphere toolbar is not visible with the new toolbar?<br>
The review in the list can be a little annoying, but is very good to start, and keep the quality of our work.<br><br>Gonzalo <br><br><br><br><div class="gmail_quote">On Thu, Mar 10, 2011 at 3:13 PM, Sebastian Silva <span dir="ltr"><<a href="mailto:sebastian@somosazucar.org">sebastian@somosazucar.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hello / Hola,<br>
<br>
As some of you know I started working with Activity Central last week, as an Activity Developer.<br>
My tasks will be to improve our Activities and also I consider, make life easier for activity developers.<br>
<br>
I'm looking forward to sharing more of what we do and have already signed up with the Activities Team.<br>
<br>
My first contribution is to update the toolbars in several activities.<br>
In the process I've run into some design decisions. In particular, with activities with few actions, updating the toolbar concealed the actions behind a ToolbarButton (see Get Books, for example). This did not seem right, so I took the liberty of moving main actions to the main toolbar. From <a href="http://wiki.sugarlabs.org/go/Features/New_Toolbar_Design#Benefit_to_Sugar" target="_blank">http://wiki.sugarlabs.org/go/Features/New_Toolbar_Design#Benefit_to_Sugar</a> - /"Make process of switching between toolbars more clear, use tool buttons that are showing all the time (in main toolbar), i.e., having Close/Help buttons visible all the time could be very useful."/ seems to support my decision.<br>
<br>
I've updated <a href="http://wiki.sugarlabs.org/go/Activity_Team/TODO#Activity_Feature_Requests" target="_blank">http://wiki.sugarlabs.org/go/Activity_Team/TODO#Activity_Feature_Requests</a> with the following.<br>
Activity Git repo with patches Comment<br>
Typing Turtle git://<a href="http://git.sugarlabs.org/%7Eicarito/typing-turtle/typing-turtle-icarito.git" target="_blank">git.sugarlabs.org/~icarito/typing-turtle/typing-turtle-icarito.git</a> DONE. Waiting for merge request.<br>
StopWatch git://<a href="http://git.sugarlabs.org/stopwatch/stopwatch.git" target="_blank">git.sugarlabs.org/stopwatch/stopwatch.git</a> DONE. Moved Share and Keep buttons to main toolbar.<br>
Help git://<a href="http://git.sugarlabs.org/%7Eicarito/help/help-newui.git" target="_blank">git.sugarlabs.org/~icarito/help/help-newui.git</a> DONE. Put navigation in main bar (like in Browse). Waiting for merge request.<br>
Distance git://<a href="http://git.sugarlabs.org/distance/distance.git" target="_blank">git.sugarlabs.org/distance/distance.git</a> DONE by dirakx.<br>
Maze git://<a href="http://git.sugarlabs.org/%7Eicarito/maze/icaritos-mainline.git" target="_blank">git.sugarlabs.org/~icarito/maze/icaritos-mainline.git</a> DONE. Moved Share to main bar. Waiting for merge request.<br>
Get Books git://<a href="http://git.sugarlabs.org/%7Eicarito/get-books/icaritos-mainline.git" target="_blank">git.sugarlabs.org/~icarito/get-books/icaritos-mainline.git</a> DONE. Moved book actions to main toolbar. Waiting for merge request.<br>
Words - Working on iticarito <<a href="http://wiki.sugarlabs.org/go/User:Icarito" target="_blank">http://wiki.sugarlabs.org/go/User:Icarito</a>>13:00, 10 March 2011 (EST). The UI can be improved.<br>
Jukebox - Working on iticarito <<a href="http://wiki.sugarlabs.org/go/User:Icarito" target="_blank">http://wiki.sugarlabs.org/go/User:Icarito</a>>13:00, 10 March 2011 (EST).<br>
<br>
<br>
I'd appreciate some feedback and peer review - as well as attention to the pending merge requests. Also on the dev workflow.<br>
<br>
Thanks, I'm happy to finally contribute code again.<br>
<br>
Sebastian<br>
_______________________________________________<br>
Sugar-Desarrollo mailing list<br>
<a href="mailto:Sugar-Desarrollo@lists.sugarlabs.org" target="_blank">Sugar-Desarrollo@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-desarrollo" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-desarrollo</a><br>
</blockquote></div><br>