Thanks Sascha<br>I have applied the 3 patchs.<br>I will push a patch with pep8 corrections now.<br><br>Gonzalo<br><br><br><div class="gmail_quote">On Thu, Feb 24, 2011 at 1:17 PM, Sascha Silbe <span dir="ltr"><<a href="mailto:silbe@activitycentral.com">silbe@activitycentral.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Since Sugar 0.86 (commit 76542527) fullscreen mode for activities works a bit<br>
differently. We're not fullscreen in an X11 (window manager) sense anymore,<br>
but rather hide some of our widgets. This caused the logic to detect<br>
fullscreen mode not to trigger and thus not to show the TopBar.<br>
<br>
Signed-off-by: Sascha Silbe <<a href="mailto:silbe@activitycentral.com">silbe@activitycentral.com</a>><br>
---<br>
 readactivity.py |   18 ++++++++----------<br>
 1 files changed, 8 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/readactivity.py b/readactivity.py<br>
index 9904910..d486f0c 100644<br>
--- a/readactivity.py<br>
+++ b/readactivity.py<br>
@@ -143,7 +143,6 @@ class ReadActivity(activity.Activity):<br>
<br>
         self.connect('key-press-event', self._key_press_event_cb)<br>
         self.connect('key-release-event', self._key_release_event_cb)<br>
-        self.connect('window-state-event', self._window_state_event_cb)<br>
<br>
         _logger.debug('Starting Read...')<br>
<br>
@@ -340,6 +339,14 @@ class ReadActivity(activity.Activity):<br>
         #else:<br>
         #    self._load_document('file:///home/smcv/tmp/test.pdf')<br>
<br>
+    def fullscreen(self):<br>
+        self._topbar.show_all()<br>
+        activity.Activity.fullscreen(self)<br>
+<br>
+    def unfullscreen(self):<br>
+        self._topbar.hide()<br>
+        activity.Activity.unfullscreen(self)<br>
+<br>
     def _create_back_button(self):<br>
         back = ToolButton('go-previous')<br>
         back.set_tooltip(_('Back'))<br>
@@ -958,15 +965,6 @@ class ReadActivity(activity.Activity):<br>
         #_logger.debug("Keyname Release: %s, time: %s", keyname, event.time)<br>
         return False<br>
<br>
-    def _window_state_event_cb(self, window, event):<br>
-        if not (event.changed_mask & gtk.gdk.WINDOW_STATE_FULLSCREEN):<br>
-            return False<br>
-<br>
-        if event.new_window_state & gtk.gdk.WINDOW_STATE_FULLSCREEN:<br>
-            self._topbar.show_all()<br>
-        else:<br>
-            self._topbar.hide()<br>
-<br>
     def __view_toolbar_needs_update_size_cb(self, view_toolbar):<br>
         if hasattr(self._view, 'update_view_size'):<br>
             self._view.update_view_size(self._scrolled)<br>
<font color="#888888">--<br>
1.7.2.3<br>
<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Gonzalo Odiard<br>SugarLabs Argentina<br><br>