Thanks. I will try changing the signal in the activities. Gonzalo <div class="gmail_quote">On Mon, Dec 6, 2010 at 10:52 AM, Benjamin Berg <<a href="mailto:benzea@sugarlabs.org">benzea@sugarlabs.org</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hello, <div class="im"> On Mon, 2010-12-06 at 11:28 +0100, Simon Schampijer wrote: > We do only set the color when the palette is popped down. This does > break the following case: > > - select text you want to change the color of > - open the color chooser and change the color > - do click anywhere in the canvas (not the selected text) and don't wait > for the palette to popdown > > ---> The text is not selected anymore when the palette pops down, hence > the new color will not be applied. > > I think the reason why Benjamin decided to set the color when the > palette is closed is that when you would emit a color change on each > change in the selector using the sliders would end up in a lot of > signaling. That is why color selectors either have a fixed set of colors > the user can select from or the custom selector with sliders is a dialog > (ok, cancel) and therefore it is known when the user has made his decision. </div>The signalling is actually happening in some way. It is possible for the application to listen to notify::color instead of color-set to do a live update of the preview. I have to admit that the issue with the text selection is rather unfortunate. A workaround for this would be nice to have and the solution may be to use notify::color instead. However, I do think that the real underlying issue is that a click to the canvas should *not* have any effect. Unfortunately implementing this is non-trivial, as it requires grabbing the input while still keeping the rest of the toolbar working (much like menu navigation in normal GTK+ applications). About the patch itself. It is wrong to remove the self.notify('color'). If anything the self.emit('color-set') could be added in (some) places. Benjamin <div class="im"> > On 12/02/2010 03:27 PM, Gonzalo Odiard wrote: </div><div class="im">> > diff --git a/src/sugar/graphics/colorbutton.py b/src/sugar/graphics/colorbutton.py > > index 1fed96d..c36320a 100644 > > --- a/src/sugar/graphics/colorbutton.py > > +++ b/src/sugar/graphics/colorbutton.py > > @@ -125,7 +125,7 @@ class _ColorButton(gtk.Button): > > self._preview.fill_color = get_svg_color_string(self._color) > > if self._palette: > > self._palette.props.color = self._color > > - self.notify('color') > > + self.emit('color-set') > > > > def get_color(self): > > return self._color </div><div><div></div><div class="h5">_______________________________________________ Sugar-devel mailing list <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> </div></div></blockquote></div>