Team, <br><br>I tried sending a patch to this thread by following the standard procedure of copying and pasting the message id to the "in-reply-to : ". However, for some reason the patch goes on to the different thread. <br>

<br>Please find the link to the patch, <a href="http://patchwork.sugarlabs.org/patch/519/">http://patchwork.sugarlabs.org/patch/519/</a><br><br><br>Shan<br><br><div class="gmail_quote">On Mon, Dec 6, 2010 at 4:36 PM, Shanjit Singh Jajmann <span dir="ltr"><<a href="mailto:shanjit@seeta.in">shanjit@seeta.in</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Team, <br><br>I thank you all for having a look at the patch and for recommending necessary changes.<br>

<br>I am sending a revised patch for the same. <br><br>Feedback and Response appreciated.<br><br><br>Shan<div><div></div><div class="h5"><br><br><div class="gmail_quote">
On Sat, Nov 13, 2010 at 6:45 PM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">


Reviewed-By: <a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a><div><div></div><div><br><br><div class="gmail_quote">On Sat, Nov 13, 2010 at 7:08 AM,  <span dir="ltr"><<a href="mailto:shanjit@seeta.in" target="_blank">shanjit@seeta.in</a>></span> wrote:<br>



<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">From: Shanjit Singh Jajmann <<a href="mailto:shanjit@seeta.in" target="_blank">shanjit@seeta.in</a>><br>




<br>
Muting by clicking on the icon is killed.<br>
---<br>
 extensions/deviceicon/speaker.py |   10 ----------<br>
 1 files changed, 0 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py<br>
index 3a54464..4242105 100644<br>
--- a/extensions/deviceicon/speaker.py<br>
+++ b/extensions/deviceicon/speaker.py<br>
@@ -50,9 +50,6 @@ class DeviceView(TrayIcon):<br>
<br>
         self.connect('expose-event', self.__expose_event_cb)<br>
<br>
-        self._icon_widget.connect('button-release-event',<br>
-                                  self.__button_release_event_cb)<br>
-<br>
         self._update_info()<br>
<br>
     def create_palette(self):<br>
@@ -73,13 +70,6 @@ class DeviceView(TrayIcon):<br>
         self.icon.props.icon_name = get_icon_state(name, current_level, step=-1)<br>
         self.icon.props.xo_color = xo_color<br>
<br>
-    def __button_release_event_cb(self, widget, event):<br>
-        if event.button == 1:<br>
-            self._model.props.muted = not self._model.props.muted<br>
-            return True<br>
-        else:<br>
-            return False<br>
-<br>
     def __expose_event_cb(self, *args):<br>
         self._update_info()<br>
<font color="#888888"><br>
--<br>
1.7.2.2<br>
<br>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</font></blockquote></div><br>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br>