<div class="gmail_quote">On Wed, Nov 3, 2010 at 12:24 AM, Anish Mangal <<a href="mailto:anish@sugarlabs.org">anish@sugarlabs.org</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Hi, Thank you for the patch, however, * I'd prefer two patches for two different changes (layout compatibility fix, edit toolbar), as I mailed earlier. </blockquote><div> Ok, resolve first the last. Does not have sense make two patches if you don't want to use these changes. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> * Your patch moves the activity-exit button to the left for sugar 0.88+. This [1] is how it should look. </blockquote><div> Done </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> * Regarding the layout-fix, your patch introduces a 'new toolbar' to contain the run/stop/clear buttons. There have been discussions on list[2] and on IRC w/ erikos, garycmartin (IIRC), and we had decided on keeping the old pippy layout for sugar <=0.84. I'd like to keep it that way unless you can throw a good argument into the mix. </blockquote><div> I think we can discuss if is better have two toolbars (one for run/stop/clear and another to edit buttons) or have only one toolbar. In Sugar usually we use a separated toolbar to the edit buttons, but a development environment like Pippy can be a exception. About using a toolbar or the old gtk buttons, my arguments are: * The activity looks more integrated to Sugar * Better screen usage * The code is cleaner. May be Gary and Simon can take a look again? Gonzalo Attached is the patch wth the quit button at the right. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> [1] <a href="http://people.sugarlabs.org/anish/pippy.png" target="_blank">http://people.sugarlabs.org/anish/pippy.png</a> [2] <a href="http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025756.html" target="_blank">http://lists.sugarlabs.org/archive/sugar-devel/2010-July/0My arguments are:25756.html</a> <div><div></div><div class="h5"> On Wed, Nov 3, 2010 at 8:10 AM, Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org">godiard@sugarlabs.org</a>> wrote: > This patch modify the last two patches from Anish to enable the use of the > right toolbars in every Sugar version. > There are screenshots here: > <a href="http://dev.laptop.org/%7Egonzalo/pippy-in-sugar-0.84.png" target="_blank">http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.84.png</a> > <a href="http://dev.laptop.org/%7Egonzalo/pippy-in-sugar-0.90.png" target="_blank">http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.90.png</a> > > Gonzalo > </div></div>> _______________________________________________ > Sugar-devel mailing list > <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > -- Anish </blockquote></div> -- Gonzalo Odiard SugarLabs Argentina