Aleksey, James,<br><br>Thank you. Appreciate your feedback.<br>I have resubmitted a revised patch as per pep8 standards<br><br><a href="http://lists.sugarlabs.org/archive/sugar-devel/2010-October/027863.html" target="_blank">http://lists.sugarlabs.org/archive/sugar-devel/2010-October/027863.html</a><br>
<br>James,<br><br> resume_label = _('No activity installed to start entry')<br><br>For now, I have kept the wordings to be as per Bug Description at the bugtracker. We can have a discussion on it.<br><br>Looking forwards to your feedback.<br>
<br>Regards,<br>
<br>Mukul Gupta<br><br><div class="gmail_quote">On Fri, Oct 15, 2010 at 4:55 AM, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>On Thu, Oct 14, 2010 at 11:32:34PM +0530, Mukul Gupta wrote:<br>
</div><div>> The patch disables the Start and Start With menu items for files<br>
> which can't be opened by any installed activity and instead<br>
> replace it with a hover dropdown with a menu item 'No activity<br>
> installed to start entry'<br>
<br>
</div>The patch added four trailing whitespace errors, according to "git am"<br>
... which is where there are space or tab characters at the end of the<br>
line. I use an editor which shows them.<br>
<br>
The patch also changed spaces to tabs, for the affected area. Once I<br>
removed them and regenerated the diff, I understood the change better.<br>
<div><br>
diff --git a/src/jarabe/journal/palettes.py b/src/jarabe/journal/palettes.py<br>
</div>index 7c3e5ff..14024fd 100644<br>
<div>--- a/src/jarabe/journal/palettes.py<br>
+++ b/src/jarabe/journal/palettes.py<br>
</div>@@ -62,22 +62,30 @@ class ObjectPalette(Palette):<br>
<div> Palette.__init__(self, primary_text=title,<br>
icon=activity_icon)<br>
<br>
- if metadata.get('activity_id', ''):<br>
- resume_label = _('Resume')<br>
- resume_with_label = _('Resume with')<br>
- else:<br>
- resume_label = _('Start')<br>
- resume_with_label = _('Start with')<br>
- menu_item = MenuItem(resume_label, 'activity-start')<br>
- menu_item.connect('activate', self.__start_activate_cb)<br>
- self.menu.append(menu_item)<br>
- menu_item.show()<br>
</div>+ if misc.get_activities(metadata):<br>
<div>+ if metadata.get('activity_id', ''):<br>
+ resume_label = _('Resume')<br>
+ resume_with_label = _('Resume with')<br>
+ else:<br>
+ resume_label = _('Start')<br>
+ resume_with_label = _('Start with')<br>
+ menu_item = MenuItem(resume_label, 'activity-start')<br>
+ menu_item.connect('activate', self.__start_activate_cb)<br>
+ self.menu.append(menu_item)<br>
+ menu_item.show()<br>
<br>
- menu_item = MenuItem(resume_with_label, 'activity-start')<br>
- self.menu.append(menu_item)<br>
- menu_item.show()<br>
- start_with_menu = StartWithMenu(self._metadata)<br>
- menu_item.set_submenu(start_with_menu)<br>
</div>+ menu_item = MenuItem(resume_with_label, 'activity-start')<br>
<div><div></div><div>+ self.menu.append(menu_item)<br>
+ menu_item.show()<br>
+ start_with_menu = StartWithMenu(self._metadata)<br>
+ menu_item.set_submenu(start_with_menu)<br>
+<br>
+ else:<br>
+ resume_label = _('No activity installed to start entry')<br>
+ menu_item = MenuItem(resume_label)<br>
+ menu_item.set_sensitive(False)<br>
+ self.menu.append(menu_item)<br>
+ menu_item.show()<br>
<br>
client = gconf.client_get_default()<br>
color = XoColor(client.get_string('/desktop/sugar/user/color'))<br>
</div></div><font color="#888888">--<br>
James Cameron<br>
<a href="http://quozl.linux.org.au/" target="_blank">http://quozl.linux.org.au/</a><br>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</font></blockquote></div><br>