Thanks for reviewing it, James.<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> if have_ofw_tree():<br>
sn = read_ofw('mfg-data/SN')<br>
uuid_ = read_ofw('mfg-data/U#')<br>
sn = sn or 'SHF00000000'<br>
uuid_ = uuid_ or '00000000-0000-0000-0000-000000000000'<br>
<div class="im"><br>
> else:<br>
> sn = generate_serial_number()<br>
> uuid_ = str(uuid.uuid1())<br>
> - setting_name = '/desktop/sugar/collaboration/jabber_server'<br>
> - jabber_server = client.get_string(setting_name)<br>
> - store_identifiers(sn, uuid_, jabber_server)<br>
> +<br>
> + setting_name = '/desktop/sugar/collaboration/jabber_server'<br>
> + jabber_server = client.get_string(setting_name)<br>
> + store_identifiers(sn, uuid_, jabber_server)<br>
> +<br>
> + if jabber_server:<br>
> url = 'http://' + jabber_server + ':8080/'<br>
<br>
</div>You are effectively repeating the previous if statement but using the<br>
output ... seems a bit obscure.<font color="#888888"><br></font></blockquote><br>
<div> ^^ Before applying this : The url (url for registration) was set from gconf only for non-XO devices.<br>I moved that outside the first if..else you have quoted, so that on all devices the url is taken from the gconf property (/desktop/sugar/collaboration/jabber_server)<br>
<br>the second 'if jabber_server:' is put there to check whether the jabber_server retrieved from the gcnof property is empty or unset. If jabber_server is a valid one, then change url, other wise keep the url = initialized one.<br>
<br>I actually went with the above modification due to the chain of mails here : <a href="http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025265.html">http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025265.html</a><br>
<br>Regards,<br>Dipankar<br></div></div>