<div class="gmail_quote">On Wed, Jul 28, 2010 at 12:14 PM, Frederick Grose <span dir="ltr"><<a href="mailto:fgrose@gmail.com">fgrose@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div class="im">On Wed, Jul 28, 2010 at 10:02 AM, Daniel Castelo <span dir="ltr"><<a href="mailto:dcastelo@plan.ceibal.edu.uy" target="_blank">dcastelo@plan.ceibal.edu.uy</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div>On Tue, Jul 27, 2010 at 11:51 PM, Frederick Grose <span dir="ltr"><<a href="mailto:fgrose@gmail.com" target="_blank">fgrose@gmail.com</a>></span> wrote:</div></div></blockquote></div></div>
</blockquote><div> </div></div><div class="gmail_quote">{...} </div><div class="gmail_quote"><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
<div class="gmail_quote"><div>See <a href="https://bugs.sugarlabs.org/ticket/1512" target="_blank">https://bugs.sugarlabs.org/ticket/1512</a></div>
</div></blockquote></div><div><br>Great. Thanks!<br>
The trac ticket suggest a new behavour:<br>
<br>
"The download event record, as a system event, might have a 'hide event'
option or not be erasable. The code bundle behind the event should,
perhaps, only be erased from the Home list view
(installed-Activity-code-bundle management), while system or Activity
events and their associated object instances are managed from the
Journal of Activity event instances."<br>
<br>
Which is the next step that I should follow to solve this issue? I
suppose that is to discuss in this email list which could be the best
solution.</div></div></blockquote><div><br></div></div><div>As noted, the problem of inadvertent deletion of updated or newly added Activity bundles may occur in the Journal or in the Home list view (through the erase action in an extended palette). The most comprehensive solution might involve grouping of Journal items [1], but that won't be quick.</div>
<div><br></div><div>A quicker solution may be to recognize the Journal entry type or kind in the Journal (if that is sufficient) and hide or remove the 'erase' entry action from the palette in the Journal. This would force intentional erasure to occur in the Home list view, where the intent may be clearer.</div>
<div><br></div><div>Alternatively, erasure from the Journal could be disabled for these entries unless they were in a filtered, Journal view (by their kind, a kind which currently is not available in the filter list).</div>
<div><br></div><div> --Fred</div><div><br></div><div>[1] This discussion thread, <a href="http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025615.html" target="_blank">http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025615.html</a>, and this wiki page, <a href="http://wiki.sugarlabs.org/go/Talk:Features/Content_support" target="_blank">http://wiki.sugarlabs.org/go/Talk:Features/Content_support</a>, describes a Journal group design for supporting Activity and content grouping.</div>
</div></blockquote><div><br></div><div>From <a href="http://bugs.sugarlabs.org/ticket/1512#comment:4">http://bugs.sugarlabs.org/ticket/1512#comment:4</a> :</div><div><br></div><div>Replying to FGrose:</div></div><div class="gmail_quote">
<div>"This behavior in the Journal is inconsistent with other 'installed' Activities, which are erased (un-installed) with a warning dialog from the Home list view."<br> </div></div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;">
</blockquote>I agree with this. In the practice it gets very confusing for everyone, mostly because there is no warning at all.<br><br><div class="gmail_quote">I really do not share the idea of bounding the installed activity with the bundle that it was used for "installing". In the practice (again) the current behavior just produces an unnecessary storage space waste (mostly because there could be many bundles in the journal for the same activity).</div>
<blockquote class="webkit-indent-blockquote gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
</blockquote><div class="gmail_quote"><div><br></div></div><div class="gmail_quote">The solution I found for this issue is jut not to delete de installed version. Please see the attachment. <div>(here:)</div><div>From dcafb30f3e96eaf0beaa41277d49f1bf8f0c3587 Mon Sep 17 00:00:00 2001</div>
<div>From: Martin Abente <<a href="mailto:mabente@paraguayeduca.org">mabente@paraguayeduca.org</a>></div><div>Date: Wed, 28 Jul 2010 17:53:30 -0400</div><div>Subject: [PATCH] Journal xobundle removal wont remove installed one</div>
<div>Organization: Paraguay Educa</div><div><br></div><div>Journal Xo bundles removal also removes the installed activity. There</div><div>are many scenarios where this behavior is it not desired. Therefore it</div><div>
needs to be changed.</div>
<div>---</div><div> src/jarabe/journal/palettes.py | 5 -----</div><div> 1 files changed, 0 insertions(+), 5 deletions(-)</div><div><br></div><div>diff --git a/src/jarabe/journal/palettes.py b/src/jarabe/journal/palettes.py</div>
<div>index 0e7702d..7c3e5ff 100644</div><div>Index: src/jarabe/journal/palettes.py</div><div>===================================================================</div><div>--- a/src/jarabe/journal/palettes.py</div><div>+++ b/src/jarabe/journal/palettes.py</div>
<div>@@ -128,11 +128,6 @@</div><div> self._temp_file_path = None</div><div> </div><div> def __erase_activate_cb(self, menu_item):</div><div>- registry = bundleregistry.get_registry()</div><div>-</div><div>
- bundle = misc.get_bundle(self._metadata)</div><div>- if bundle is not None and registry.is_installed(bundle):</div><div>- registry.uninstall(bundle)</div><div> model.delete(self._metadata['uid'])</div>
<div> </div><div> def __detail_activate_cb(self, menu_item):</div><div><br></div><div>This is probably the simplest fix.</div><div><br></div><div>The bundle installation event records were kept in the Journal as a record of learner events, but as we've experienced, they provide little, lasting value and were wired with destructive behavior.</div>
<div><br></div><div>(When we implement Journal grouping or multi Journals, they could presumably have counterpart entries in the 'System' Journal filter, even after they were scrubbed from 'My' Journal.)</div>
<div><br></div><div> --Fred</div><div><br></div><div>post script:</div><div>We need to be careful with confusing terminology with Activities, bundles, and events.</div><div>The code names, here, provide some guidance: (Journal) item metadata and (Activity) bundle. </div>
</div><br>