Hi all<br><br>ref <a href="http://bugs.sugarlabs.org/ticket/2062">http://bugs.sugarlabs.org/ticket/2062</a><br><br>Simple fix, have captured the exception that's raised and have told user to connect to the nework:<br><br>
<pre>This commit fixes sl#2062. This bug causes XS registrations<br>to fail silently when the XO is offline. The fix is to<br>catch the TypeError & provide an alert to the user upon<br>failure.<br>---<br> src/jarabe/desktop/favoritesview.py | 6 ++++++<br>
1 files changed, 6 insertions(+), 0 deletions(-)<br><br>diff --git a/src/jarabe/desktop/favoritesview.py b/src/jarabe/desktop/favoritesview.py<br>index aca945a..45fa305 100644</pre>
<table style="display: none;" class="inline" summary="Differences" cellspacing="0">
<colgroup><col class="lineno"><col class="lineno"><col class="content"></colgroup>
<thead>
<tr>
<th title="File a/src/jarabe/desktop/favoritesview.py">
a
</th>
<th title="File b/src/jarabe/desktop/favoritesview.py">
b
</th>
<th> </th>
</tr>
</thead>
<tbody class="unmod">
<tr>
<th>323</th><th>323</th><td class="l"><span> except RegisterError, e:</span> </td>
</tr><tr>
<th>324</th><th>324</th><td class="l"><span> alert.props.title = _('Registration Failed')</span> </td>
</tr><tr>
<th>325</th><th>325</th><td class="l"><span> alert.props.msg = _('%s') % e</span> </td>
</tr>
</tbody><tbody class="add">
<tr class="first">
<th> </th><th>326</th><td class="r"><ins> except TypeError:</ins> </td>
</tr><tr>
<th> </th><th>327</th><td class="r"><ins> # raised by xmlrpclib.py when XO attempts to</ins> </td>
</tr><tr>
<th> </th><th>328</th><td class="r"><ins> # register itelf while offline: sl#2062</ins> </td>
</tr><tr>
<th> </th><th>329</th><td class="r"><ins> alert.props.title = _('Registration Failed')</ins> </td>
</tr><tr>
<th> </th><th>330</th><td class="r"><ins> alert.props.msg = _('Please try connecting to '\</ins> </td>
</tr><tr class="last">
<th> </th><th>331</th><td class="r"><ins> 'the network.')</ins> </td>
</tr>
</tbody><tbody class="unmod">
<tr>
<th>326</th><th>332</th><td class="l"><span> else:</span> </td>
</tr><tr>
<th>327</th><th>333</th><td class="l"><span> alert.props.title = _('Registration Successful')</span> </td>
</tr><tr>
<th>328</th><th>334</th><td class="l"><span> alert.props.msg = _('You are now registered ' \</span> </td>
</tr>
</tbody>
</table><pre style="display: block;">Index: src/jarabe/desktop/favoritesview.py<br>===================================================================<br>--- a/src/jarabe/desktop/favoritesview.py<br>+++ b/src/jarabe/desktop/favoritesview.py<br>
@@ -323,6 +323,12 @@<br> except RegisterError, e:<br> alert.props.title = _('Registration Failed')<br> alert.props.msg = _('%s') % e<br>+ except TypeError:<br>+ # raised by xmlrpclib.py when XO attempts to<br>
+ # register itelf while offline: sl#2062<br>+ alert.props.title = _('Registration Failed')<br>+ alert.props.msg = _('Please try connecting to '\<br>+ 'the network.')<br>
else:<br> alert.props.title = _('Registration Successful')<br> alert.props.msg = _('You are now registered ' \</pre><br>