<html><body bgcolor="#FFFFFF"><div>Hi Akash,<br><br>On 25 Jun 2010, at 07:46, Akash Gangil <<a href="mailto:akashg1611@gmail.com">akashg1611@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">On Fri, Jun 25, 2010 at 8:49 AM, Gary Martin <span dir="ltr"><<a href="mailto:garycmartin@googlemail.com"><a href="mailto:garycmartin@googlemail.com">garycmartin@googlemail.com</a></a>></span> wrote:</span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Akash,<br>
<div class="im"><br>
On 24 Jun 2010, at 21:25, Akash Gangil wrote:<br>
<br>
> Hi Gary,<br>
><br>
>> Make your changes, commit, push, and then request a merge?<br>
><br>
> I have filed the merge request.Please look into it. Also I made it backward compatible to previous sugar versions as you suggested. It would fall back to older toolbar design in case of previous sugar versions.<br>
<br>
</div>I've just tested under Sugar 0.88, 0.84, and 0.82.</blockquote><div><br></div><div>Hey, is there any way I too can test my work on all sugar versions? Currently I use jhbuild on ubuntu lucid, which I think runs 0.88 version of sugar in </div></div></div></blockquote><div><br></div><div>For ease of development I usually use a current Sugar build (0.88) running under Fedora in VirtualBox on a Mac. I'm using F13 at the moment with the Sugar Desktop package made by the SoaS folks (<span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.289062); -webkit-composition-fill-color: rgba(175, 192, 227, 0.222656); -webkit-composition-frame-color: rgba(77, 128, 180, 0.222656); ">jhbuild <span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">broke for me under F11 and I didn't have time to diagnose why - seemed to need a newer version of GTK+ than was shipping in F11). </span></span></div><div><br></div><div>For older Sugar versions I have two XO-1's and one XO-B4. It might be possible to run some old builds in VirtualBox for testing, but I've not tried that route myself (I do like to test on XO-1 hardware as that is what 99% of our users are using).</div><div><br></div><div>Regards,</div><div>--Gary </div><br><blockquote type="cite"><div><div class="gmail_quote">
<div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.289062); -webkit-composition-fill-color: rgba(175, 192, 227, 0.222656); -webkit-composition-frame-color: rgba(77, 128, 180, 0.222656); color: rgb(0, 80, 1); ">I am going to merge your patch tomorrow, but will also make a couple changes of my own before making the next official release:</span><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
1) Testing with 0.84 and 0.82 displays multiple create tabs running off the right edge of the screen, the first create tab contains the correct tools, all the others are empty.<br>
<br>
<br><br>
<br>
2) I like your new create icon (shown below), however I'm going to try and place all the tool buttons up in the primary toolbar so we make maximum use of that available space. The Sugar HIG allows for up to 16 icons, so we should be fine putting all the current tools there (and still have room for one or two more new tool button features on my todo list).<br>
<br>
<br><br>
<br>
Thanks again for your effort! Hopefully I'll be able to make a new release over this weekend :)<br>
<br>
Kind Regards,<br>
--Gary<br>
<br>
>> Having a quick scan through the below patch I don't see any fallback to the old toolbar setup if someone is running an older version of Sugar. I don't want to loose compatibility 99% of our current user base if at all possible (check the git reps of Moon, Calculator, TurtleArt, and I'm sure many other activities for dual toolbar support).<br>
>><br>
>> Thanks again for taking the time to submit a patch.<br>
>><br>
>> Kind Regards,<br>
>> --Gary<br>
<br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Best Regards<br>Akash Gangil<br><br>
</div></blockquote></body></html>