Andres! Gol de Uruguay? Gonzalo <div class="gmail_quote">On Sun, Jun 13, 2010 at 9:49 PM, Michael Stone <<a href="mailto:michael@laptop.org">michael@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Sun, Jun 13, 2010 at 08:43:19PM -0300, Andrés Ambrois wrote: >In that case write() was called with file_path=None by copy() and a >TypeError was raised by os.path.exists(). > >Signed-off-by: Andrés Ambrois <<a href="mailto:andresambrois@gmail.com">andresambrois@gmail.com</a>> >--- > src/jarabe/journal/model.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/src/jarabe/journal/model.py b/src/jarabe/journal/model.py >index ae77e72..fd3d3db 100644 >--- a/src/jarabe/journal/model.py >+++ b/src/jarabe/journal/model.py >@@ -492,7 +492,7 @@ def write(metadata, file_path='', update_mtime=True, transfer_ownership=True): > file_path, > transfer_ownership) > else: >- if not os.path.exists(file_path): >+ if not file_path or not os.path.exists(file_path): > raise ValueError('Entries without a file cannot be copied to ' > 'removable devices') > >-- >1.6.3.3 </div>Reviewed-by: Michael Stone <<a href="mailto:michael@laptop.org">michael@laptop.org</a>> Looks good to me; merged into my personal tree. Michael <div><div></div><div class="h5">_______________________________________________ Sugar-devel mailing list <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> </div></div></blockquote></div> -- Gonzalo Odiard Responsable de Desarrollo Sistemas Australes