I have drawed cursors for the other tools. What do you think? If the patch its bad, I can send you the images. Gonzalo <div class="gmail_quote">On Wed, May 26, 2010 at 1:42 AM, James Cameron <<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Tue, May 25, 2010 at 06:40:44AM -0300, Gonzalo Odiard wrote: > Use standard cursors for pencil, brush, eraser and paint-bucket. The > other tools need a custom cursor. > Bugs #40, #296 and OLPC #4316, #8864 </div>Reviewed and tested ... 1. does fix <a href="http://dev.laptop.org" target="_blank">dev.laptop.org</a> #4316, 2. doesn't properly fix <a href="http://sugarlabs.org" target="_blank">sugarlabs.org</a> #296, some additional tuning of coordinates may be needed; drawing effect still appears at an offset, 3. doesn't fix <a href="http://sugarlabs.org" target="_blank">sugarlabs.org</a> #40, in that the other cursors continue to be invisible against similar backgrounds, 4. doesn't remove images/{pencil,brush,bucket,eraser}.png The coding style was a bit repetitive, here's an alternate method which uses a dictionary and wraps the code better: >From e430f2742f910d16a59318060bd39fc80e37822b Mon Sep 17 00:00:00 2001 From: James Cameron <<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> Date: Wed, 26 May 2010 14:36:13 +1000 Subject: [PATCH] use cursors from Sugar theme Use Sugar theme cursors for pencil, brush, eraser and paint-bucket. <a href="http://dev.laptop.org/ticket/4316" target="_blank">http://dev.laptop.org/ticket/4316</a> --- Area.py | 14 ++++++++++++-- <div class="im"> 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/Area.py b/Area.py </div>index 611f944..8af2b9b 100644 <div class="im">--- a/Area.py +++ b/Area.py </div>@@ -1057,8 +1057,18 @@ class Area(gtk.DrawingArea): <div class="im"> # Setting the cursor try: - pixbuf = gtk.gdk.pixbuf_new_from_file('./images/' + tool['name'] + '.png') - cursor = gtk.gdk.Cursor(gtk.gdk.display_get_default() , pixbuf, 6, 21) </div>+ cursors = { 'pencil': 'pencil', + 'brush': 'paintbrush', + 'eraser': 'eraser', + 'bucket': 'paint-bucket' } + display = gtk.gdk.display_get_default() + if self.tool['name'] in cursors: + name = cursors[self.tool['name']] + cursor = gtk.gdk.cursor_new_from_name(display, name) + else: + filename = os.path.join('images', tool['name'] + '.png') + pixbuf = gtk.gdk.pixbuf_new_from_file(filename) + cursor = gtk.gdk.Cursor(display, pixbuf, 6, 21) <div class="im"> except gobject.GError: cursor = None </div>-- 1.7.1 > _______________________________________________ > Sugar-devel mailing list > <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> -- James Cameron <a href="http://quozl.linux.org.au/" target="_blank">http://quozl.linux.org.au/</a> </blockquote></div> -- Gonzalo Odiard Responsable de Desarrollo Sistemas Australes