<br><br><div class="gmail_quote">On Wed, May 19, 2010 at 1:47 AM, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Tue, May 18, 2010 at 04:26:44PM -0300, Daniel Castelo wrote:<br> > I have this ticket pending, could you give your feedback? Thanks!!!<br> > <a href="http://bugs.sugarlabs.org/ticket/1759" target="_blank">http://bugs.sugarlabs.org/ticket/1759</a><br> ><br> > This patch improves the feature 3G Support (added in 0.88).<br> <br> </div>It was also backported to 0.84, so the mention of 0.88 is probably<br> unnecessarily restrictive.<br></blockquote><div> </div><div>The patch was created before that the feature has been backported</div><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Also, the same changes apply to other wireless network types, not just<br> 3G, so I don't think "3G Support" is the right description.<br></blockquote><div><br>Maybe you are right, but the feature has this name: <a href="http://wiki.sugarlabs.org/go/Features/3G_Support">http://wiki.sugarlabs.org/go/Features/3G_Support</a><br> </div><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> By the way, if you produce a 0.84 re-spin, then I can easily test it for<br> you. See sucrose-0.84 branch in<br> git://<a href="http://git.sugarlabs.org/sugar/mainline.git" target="_blank">git.sugarlabs.org/sugar/mainline.git</a><br> <div class="im"><br></div></blockquote><div>Backporting this patch to 0.84 is not trivial, i will try. <br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im"> > Includes:<br> > Show the connection errors<br> > Apply Eben's Mockup: <a href="http://wiki.sugarlabs.org/go/File:3G_device.png" target="_blank">http://wiki.sugarlabs.org/go/File:3G_device.png</a><br> ><br> ><br> > ---<br> </div><div class="im">> index 94a4293..995446c 100644<br> > --- a/extensions/deviceicon/network.py<br> > +++ b/extensions/deviceicon/network.py<br> </div><div class="im">> @@ -267,35 +282,89 @@ class GsmPalette(Palette):<br> <br> </div>...<br> <br> > + def _get_error_by_nm_reason(self, reason):<br> <div class="im">> + if reason in [network.NM_DEVICE_STATE_REASON_NO_SECRETS,<br> > network.NM_DEVICE_STATE_REASON_GSM_PIN_CHECK_FAILED]:<br> > + message = _('The Pin/Puk configuration is not valid.')<br> <br> </div>There can be other explanations for this reason, such as incorrect SIM<br> inserted. It is better to stick to the meaning; "PIN check failed."<br></blockquote><div></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> > + elif reason in [network.NM_DEVICE_STATE_REASON_PPP_DISCONNECT,<br> <div class="im">> network.NM_DEVICE_STATE_REASON_PPP_FAILED]:<br> > + message = _('Check the APN configuration.')<br> <br> </div>While APN is indeed known to cause PPP_DISCONNECT and PPP_FAILED, there<br> are many other reasons, and so it is incorrect to specifically identify<br> APN as the only cause. An invalid APN is a common cause, but not the<br> only cause. Another cause commonly seen is lack of radio signal or<br> antenna.<br></blockquote><div><br>Maybe we have to shown two messages, the error message ("PPP_DISCONNECT") and a possible solution to the user ("Check the APN configuration.")<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <br> Also, "Access Point Name (APN)" is how it is described in the Modem<br> Configuration control panel, and so that is how you should describe it<br> in a message.<br> <br> > + elif reason in [network.NM_DEVICE_STATE_REASON_MODEM_NO_CARRIER]:<br> <div class="im">> + message = _('Check the tel number configuration.')<br> <br> </div>Again, this is not the only reason this can occur.<br> <br> Also, "tel number" is not the way it is described in the control panel,<br> it uses "Number".<br> <br> > + elif reason in [network.NM_DEVICE_STATE_REASON_MODEM_DIAL_TIMEOUT]:<br> <div class="im">> + message = _('Time out. Check the tel configuration')<br> <br> </div>"tel number" should be "Number".<br> <br> > + else:<br> > + message = _('Unexpected error.')<br> <br> More should be handled.<br> <br> > + return message<br> <div class="im">> +<br> > def __toggle_state_cb(self, menuitem):<br> > if self._current_state == _GSM_STATE_NOT_READY:<br> > pass<br> <br> </div>...<br> <div class="im"><br> > index 3a949da..579ed8d 100644<br> > --- a/src/jarabe/model/network.py<br> > +++ b/src/jarabe/model/network.py<br> > @@ -54,6 +54,13 @@ NM_ACTIVE_CONNECTION_STATE_UNKNOWN = 0<br> > NM_ACTIVE_CONNECTION_STATE_ACTIVATING = 1<br> > NM_ACTIVE_CONNECTION_STATE_ACTIVATED = 2<br> ><br> > +NM_DEVICE_STATE_REASON_NO_SECRETS = 7<br> > +NM_DEVICE_STATE_REASON_PPP_DISCONNECT = 13<br> > +NM_DEVICE_STATE_REASON_PPP_FAILED = 14<br> > +NM_DEVICE_STATE_REASON_MODEM_NO_CARRIER = 25<br> > +NM_DEVICE_STATE_REASON_MODEM_DIAL_TIMEOUT = 26<br> > +NM_DEVICE_STATE_REASON_GSM_PIN_CHECK_FAILED = 34<br> <br> </div>You seem to have selected a subset of available NM_DEVICE_STATE_REASON<br> values. A larger list is at<br> <br> <a href="http://projects.gnome.org/NetworkManager/developers/spec.html" target="_blank">http://projects.gnome.org/NetworkManager/developers/spec.html</a></blockquote><div><br>I have consult this list. We try to catch just the most common messages. <br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <br> and shows several reasons that an Australian deployment would expect to<br> encounter with the Australian wireless broadband provider networks.<br> <br> I think more reasons should be handled.<br> <font color="#888888"><br></font></blockquote><div><br> I'd like to know which error messages we should show in each case.<br><br>Thanks for your comments/corrections!<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <font color="#888888"> --<br> James Cameron<br> <a href="http://quozl.linux.org.au/" target="_blank">http://quozl.linux.org.au/</a><br> </font></blockquote></div><br><br clear="all"><br>-- <br>Ing. Daniel Castelo<br>Plan Ceibal - Área Técnica<br>Avda. Italia 6201<br>Montevideo - Uruguay.<br>Tel.: 601.57.73 Interno 2228<br>E-mail : <a href="mailto:dcastelo@plan.ceibal.edu.uy">dcastelo@plan.ceibal.edu.uy</a><br>