first, tks for the awesome feedback<br><br><div class="gmail_quote">2009/12/14 Felipe López Toledo <span dir="ltr"><<a href="mailto:zer.subzero@gmail.com">zer.subzero@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
hey man,<br>
<br>
I have read the online docs, here is my feedback:<br><br>
[ feature request ] <br>add collision support for file names repeated<br></blockquote><div><br></div><div>Can you be more specific? just to avoid loading the same file twice?</div><div><br></div><div>I think that collision support for the 'name' property would also be helpful</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">[ question ] <br>how does the actual localization algorithm work?<br>
I mean, is there a way to localize all the content with one line?<br>maybe, we could explain it in the docs<br></blockquote><div><br></div><div>It doesn't work ;) ! there is no localization at all. It will have to wait until next release</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">[ bug? ]<br>maybe, I'm wrong, but I think here is an error:<br>
/docs/symbols/Karma.html<br>
- ninja1.sword === "sword" </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
+ ninja1.weapon === "sword"<br></blockquote><div><br></div><div>that is a bug, thanks for catching it</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
[ suggestion ]<br>
/docs/symbols/Karma.karma.html<br>
Karma.karma.locale<br>
what is the default value?, I suggest "en"<br></blockquote><div><br></div><div>none, right now, let me think about this.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
[ request ]<br>/docs/symbols/Karma.kCanvas.html<br>
please, delete "fps" property, atm it does not have any function.<br></blockquote><div><br></div><div>done</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
[ suggestion ]<br>
I have seen some examples with code an explanation, I suggest to add<span><span style="background-color:rgb(255, 255, 255)" title="caracteres de comentarios"> comment characters</span></span> (/* */)<br>
<br>
example:<br>
<br>
docs/symbols/Karma.karma.html<br>
Karma.karma.rand(lower, upper) <br>
var num = rand(0, 10);<br>- num could be 0, 1, 2, 3 ... or 10 <br>+ //num could be 0, 1, 2, 3 ... or 10 <-----<br></blockquote><div><br></div><div>great idea</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
[ ]<br>btw, I see there is no kimage, ksound and so on documentation, I think it is the problem with the JsDoc toolkit, right?<br><br>regards</blockquote><div><br></div><div>Yeah, it has to do with jsdoc toolkit but also the funny way I laid out kMedia prototype object for them both. I now think it is probably better that I get rid of kMedia and just split them into 3 wholly different objects without a prototypal parent. It is odd to make a concession for the documentation tool but I also think that it will make the code easier to read.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im"><br><div class="gmail_quote">2009/12/3 Bryan Berry <span dir="ltr"><<a href="mailto:bryan@olenepal.org" target="_blank">bryan@olenepal.org</a>></span><br>
<blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">argh! sorry I forgot the link<div><a href="http://karma.sugarlabs.org/docs/index.html" target="_blank">http://karma.sugarlabs.org/docs/index.html</a><br>
<br><div class="gmail_quote">2009/12/3 Bryan Berry <span dir="ltr"><<a href="mailto:bryan@olenepal.org" target="_blank">bryan@olenepal.org</a>></span><div><br>
<blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">I have added examples but there is still work to be done. Please let me know if it is hard to follow or if significant chunks are missing<div>
<br></div><div>I haven't exactly figured out how to document methods like play() since there isn't an object specific to it</div>
<div><br></div><div>I also haven't documented the kCanvas with the makeChain function. I fear that the makeChain function -- while truly a feat of metaprogramming and closure manipulation -- may be too clever. It also may not save that much typing since I will have to document each function anyways. Felipe what do you think?</div>
</blockquote></div></div><br></div>
</blockquote></div><br><br clear="all"><br></div>-- <br><font color="#888888">Felipe López Toledo<br>
</font></blockquote></div><br>