I knowingly left the most of the changes you are talking about. It was like that from subzero himself. I had plan for cleaning them up in the end. I only want to make the least change possible so that it won't be hard for me to debug.<br>
<br>Putting the grid as image in html is nice idea. Or should I use table instead of image ?<br><br>Sorry again, but I still can't do the CSS, :(.<br><br><div class="gmail_quote">On Fri, Oct 23, 2009 at 5:51 AM, Bryan Berry <span dir="ltr"><<a href="mailto:bryan@olenepal.org">bryan@olenepal.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">roxan, here are some remarks that I think would be helpful. I would be<br>
happy to go over this mail on irc w/ u.<br>
<br>
For all the stuff I have remarked here I have pushed changes to<br>
<a href="http://git.sugarlabs.org" target="_blank">git.sugarlabs.org</a><br>
<br>
===Comments on <body> in index.html and general file-naming ====<br>
<br>
I highly recommend u set the <!DOCTYPE html> this sets the doctype to<br>
html5. Without it, the browser likely won't recommend html5 elements<br>
properly or consistently<br>
<br>
Why do u link in both jquery.js and ../../js/jquery-1.3.2.min.js ?<br>
<br>
<script src="../../js/jquery-1.3.2.min.js" type="text/javascript"><br>
<br>
You named the css file activity.css, can we change this to lesson.css?<br>
I think it would make the naming more consistent and preserve the<br>
distinction between Karma lessons and Karma activities. A karma lesson<br>
is a single instructional unit and a karma activity contains multiple<br>
lessons, just like our E-Paath bundles do now.<br>
<br>
There is also a quadrilaterals.css file linked in. Why do u need<br>
activity.css and quadrilaterals.css?<br>
<br>
You have added in the jquery UI library <script<br>
src="../../js/jquery.ui.all.js" type="text/javascript"><br>
but it doesn't exist at that path.<br>
<br>
It also appears that u don't use any of the Karma api for drawing. Is<br>
that because documentation is lacking?<br>
<br>
===Layout===<br>
<br>
You want to split out the grid on the right-handside of the bg.png into<br>
a separate image and embed it into the html. That way u can position it<br>
independently.<br>
<br>
I don't recommend using absolute positioning for the buttons. You do<br>
need it for the left and right buttons because u have to position them<br>
relative to the grid image which is embedded in the background. If you<br>
split that grid out and directly place it in the layout, you can<br>
position the left and right buttons relative to it.<br>
<font color="#888888"><br>
<br>
<br>
--<br>
Bryan W. Berry<br>
Senior Engineer<br>
OLE Nepal, <a href="http://www.olenepal.org" target="_blank">http://www.olenepal.org</a><br>
<br>
</font></blockquote></div><br>