This change fixes a bug: journal is unable to do anything but "start" a bundle, even if you have an activity (Develop) which can handle the activity bundle mime type. The immediate question is: should "start" be available only by pressing the button, or should it also be an option in the pulldown? I think that the answer is an obvious yes. The longer term question is: should "start" always be the default for bundles, or should it be possible to have a bundle whose default action is "Develop"? However, discussion on this larger question should not block approving the immediate patch. <div class="gmail_quote">On Tue, Jun 10, 2008 at 10:02 AM, Eben Eliason <<a href="mailto:eben.eliason@gmail.com">eben.eliason@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> I'm confused, actually.  We already have "Start" as the first option in the palette for "raw" activities, and as the action listed on the button in the detail view.  What is the intent for the change being discussed here? - Eben <div><div></div><div class="Wj3C7c"> On Tue, Jun 10, 2008 at 5:57 AM, Tomeu Vizoso <<a href="mailto:tomeu@tomeuvizoso.net">tomeu@tomeuvizoso.net</a>> wrote: > (sorry about the big delay) > > On Wed, May 28, 2008 at 9:44 PM, Jameson Chema Quinn > <<a href="mailto:jquinn@cs.oberlin.edu">jquinn@cs.oberlin.edu</a>> wrote: >> On Wed, May 28, 2008 at 12:16 PM, Tomeu Vizoso <<a href="mailto:tomeu@tomeuvizoso.net">tomeu@tomeuvizoso.net</a>> >> wrote: >>> >>> Hi, >>> >>> +        if self._jobject.is_activity_bundle(): >>> +            menu_item = MenuItem(_('Start')) >>> +            menu_item.connect('activate', >>> self._resume_menu_item_activate_cb, >>> +                              None) >>> +            palette.menu.append(menu_item) >>> +            menu_item.show() >>> >>> Why are we adding a Start menu item? How is it different from clicking >>> on the button? >> >> We add a start menu item in case there is a choice to run or open with; if >> there are choices, they should all be listed, even if one is available in a >> simpler way (by just clicking). Also note that I plan, in the future, to >> make the default behavior (clicking on the button) configurable using >> metadata, so that you can have some bundles which are "for editing". > > Eben, can you comment on this UI change? > > Thanks, > > Tomeu > _______________________________________________ Sugar mailing list <a href="mailto:Sugar@lists.laptop.org">Sugar@lists.laptop.org</a> <a href="http://lists.laptop.org/listinfo/sugar" target="_blank">http://lists.laptop.org/listinfo/sugar</a> </div></div></blockquote></div>