Sorry, Marco, but here is yet another version of the patch. I decided to refactor the Config class out of bundlebuilder - all it was carrying in the common start() case was bundle_name; and as for other cases, it is simpler to call Builder(...params...) than Builder(Config(...params...)).<br>
<br>In the process, I cleaned up the config initialization a bit. Most significantly, I am now picking up bundle_name from ActivityBundle, which gets it from <a href="http://activity.info">activity.info</a>, so that is no longer a meaningful parameter to have to pass. (I strip whitespace from activity_name to get bundle_name).<br>
<br>And I have fixed the two leftover pylint complaints.<br><br>There are a few more changes I want to make (a few extra cmd_xxx functions for convenience), but I'll let you OK this first.<br><br>bundleManifest.all.patch = (bundleMANIFEST.patch /*included above*/ + bundleManifest.sub.patch)<br>
<br>Cheers,<br>Jameson<br><br><div class="gmail_quote">On Sat, Jun 7, 2008 at 10:24 AM, Jameson Chema Quinn <<a href="mailto:jquinn@cs.oberlin.edu">jquinn@cs.oberlin.edu</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I'm away from my machine, but quick response, I'll say more later.<div class="Ih2E3d"><br><br><br>On Sat, Jun 7, 2008 at 6:51 AM, Marco Pesenti Gritti <<a href="mailto:mpgritti@gmail.com" target="_blank">mpgritti@gmail.com</a>> wrote:<br>
</div><div class="gmail_quote"><div class="Ih2E3d">
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">I'm still getting a few pylint errors, you don't?.</blockquote></div><div><br>I was just getting "defined outside of __init__" for ActivityBundle.manifest ... I don't know how I'm supposed to fix that, since it is defined from a subroutine of __init__ that is also useful elsewhere.<br>
</div><div class="Ih2E3d"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Also can you please<br>
answer the question/notes I posted before I go ahead an do a full<br>
review?</blockquote></div><div><br>OK, here:<div class="Ih2E3d"><br><br>
* Please run pylint on the changed files. You can use<br>
sugar-jhbuild/scripts/data<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">/pylintrc. That will catch several problems<br>
and nitpicks that I'd ask you to fix anyway.</blockquote></div><div><br>Done, I think, I will check again later. <br></div><div class="Ih2E3d"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
* I dont understand all the<br>
warnings.warn(MalformedBundleException(...)). What's the purpose of<br>
those. Shouldn't they be real exceptions? What's the advantage of<br>
using the warnings module over logging.warning?</blockquote></div><div><br>
fixed in the patch I reposted<br>
</div><div class="Ih2E3d"><br>
* I'm not sure what you are using dest_dir for, but it looks like it<br>
should be part of Config.<br><br></div>again, fixed.<div class="Ih2E3d"><br><br>
* Why are you moving the activity and env imports inline.<br><br></div>I answered that in my previous email: to make it easier to use these files without having the rest of Sugar installed.<br><br></div></div><br>
</blockquote></div><br>