<div class="gmail_quote">On Wed, May 28, 2008 at 12:16 PM, Tomeu Vizoso <<a href="mailto:tomeu@tomeuvizoso.net">tomeu@tomeuvizoso.net</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Hi, +        if self._jobject.is_activity_bundle(): +            menu_item = MenuItem(_('Start')) +            menu_item.connect('activate', self._resume_menu_item_activate_cb, +                              None) +            palette.menu.append(menu_item) +            menu_item.show() Why are we adding a Start menu item? How is it different from clicking on the button? </blockquote><div> We add a start menu item in case there is a choice to run or open with; if there are choices, they should all be listed, even if one is available in a simpler way (by just clicking). Also note that I plan, in the future, to make the default behavior (clicking on the button) configurable using metadata, so that you can have some bundles which are "for editing". </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> -            self._jobject.resume(service_name) +            if not service_name: +                self._jobject.resume() +            else: +                self._jobject.resume(service_name) Why is this needed? self._jobject.resume(service_name) when service_name == None should be the same as self._jobject.resume().</blockquote><div> Fixed. </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> The rest seems good to me. Thanks, Tomeu _______________________________________________ Sugar mailing list <a href="mailto:Sugar@lists.laptop.org">Sugar@lists.laptop.org</a> <a href="http://lists.laptop.org/listinfo/sugar" target="_blank">http://lists.laptop.org/listinfo/sugar</a> </blockquote></div>