[Sugar-devel] Screenshot feature [GSoC Project]

[Sam Parkinson]

Hi Utkrash,

Can you check you uploaded the patch correctly?  I tested and you had 
solved none of the issues :(

Thanks,
Sam

On Fri, May 13, 2016 at 4:47 PM, Ütkarsh Tiwari 
<iamutkarshtiwari at gmail.com> wrote:
> Hi,
>     I have resolved almost all the issues reported by Mr. James
> Cameron here 
> -https://github.com/sugarlabs/sugar/pull/675#issuecomment-209190086
> .
> 
> There is just one thing I need help with. I need to show the popup
> window above all the active Gtk.Window(s) for eg. Controlpanel. How to
> make this happen?
> 
> Thanks,
> Utkarsh Tiwari
> 
> On 5/11/16, Ütkarsh Tiwari <iamutkarshtiwari at gmail.com> wrote:
>>  ---------- Forwarded message ----------
>>  From: Ütkarsh Tiwari <iamutkarshtiwari at gmail.com>
>>  Date: Wed, 11 May 2016 04:24:18 +0530
>>  Subject: Re: [Sugar-devel] Screenshot feature [GSoC Project]
>>  To: Tony Anderson <tony_anderson at usa.net>
>> 
>>  Hi Tony,
>>               I have re-worked the UI as you requested. Please test 
>> it
>>  and let me know your suggestions.
>> 
>>  P.R.- https://github.com/sugarlabs/sugar/pull/675
>> 
>>  Thanks,
>>  Utkarsh Tiwari
>> 
>>  On 4/9/16, Tony Anderson <tony_anderson at usa.net> wrote:
>>>  Hi, Utkarsh
>>> 
>>>  You clearly have control over the code involved. For screenshots
>>>  'cancel' is ok since the user is not also leaving an activity. 
>>> However,
>>>  for activities, 'cancel' should not be used since it suggests 
>>> canceling
>>>  the 'quit' action. I think something like: Save Yes   No  might 
>>> work.
>>>  The Yes response would be ignored unless the name is changed. If 
>>> you use
>>>  Save Yes No (or check, x), the same alert could be used for both 
>>> cases
>>>  increasing UI consistency.
>>> 
>>>  Tony
>>> 
>>>  On 04/09/2016 07:10 AM, Utkarsh Tiwari wrote:
>>>> 
>>>>  I have fixed*
>>>> 
>>>>  On Apr 9, 2016 4:19 AM, "Utkarsh Tiwari" 
>>>> <iamutkarshtiwari at gmail.com
>>>>  <mailto:iamutkarshtiwari at gmail.com>> wrote:
>>>> 
>>>>      Hi,
>>>>           I have all these following listed inconsistencies as 
>>>> suggested
>>>>  ->
>>>>      1- Esc key handler removed.
>>>>      2- Enter key hander removed.
>>>>      3- Now the screenshot can be saved only via save(check) 
>>>> toolbutton.
>>>>      4- The screenshot alert can be 'not save' or 'cancelled' via
>>>>  cancel(X)
>>>>      toolbutton.
>>>> 
>>>>      PR- https://github.com/sugarlabs/sugar/pull/675
>>>> 
>>>>      Please update me if further modifications are required.
>>>> 
>>>>      Thank you,
>>>>      Utkarsh Tiwari
>>>> 
>>>>      On 4/8/16, Tony Anderson <tony_anderson at usa.net
>>>>      <mailto:tony_anderson at usa.net>> wrote:
>>>>      > Hi,
>>>>      >
>>>>      > Consistency is very important to our users. Using Esc for 
>>>> this
>>>>      is unusual.
>>>>      >
>>>>      >
>>>>      > I have trouble following the screencast. It looks like you 
>>>> offer
>>>>      a check
>>>>      > and an x for the user. It also looks like an enter after
>>>>      providing the
>>>>      > title acts as
>>>>      > the check. The x appears to save the screenshot without 
>>>> changing
>>>>  the
>>>>      > title. The user doesn't appear to have an option not to 
>>>> save the
>>>>      > screenshot. Arguably the workflow would be to complete the 
>>>> task
>>>>      and then
>>>>      > go to the Journal to erase the unneeded screenshots. I have 
>>>> taken
>>>>      > screenshots and realized, for example, that the cursor was 
>>>> not
>>>>      on the
>>>>      > right toolbar item. For these, I would like to be able to 
>>>> have a
>>>>  'no
>>>>      > save' option.
>>>>      >
>>>>      > Using Esc is not consistent with the way the rest of Sugar 
>>>> works
>>>>  and
>>>>      > doesn't seem needed since you offer an equivalent one-click
>>>>      option in
>>>>      > the alert/pop-up.
>>>>      >
>>>>      > Tony
>>>>      >
>>>>      > On 04/08/2016 02:07 PM, Utkarsh Tiwari wrote:
>>>>      >> Hi,
>>>>      >>      Here is the PR to the screenshot feature ->
>>>>      >> https://github.com/sugarlabs/sugar/pull/675
>>>>      >>
>>>>      >> Thank you,
>>>>      >> Utkarsh Tiwari
>>>>      >>
>>>>      >> On 4/4/16, Utkarsh Tiwari <iamutkarshtiwari at gmail.com
>>>>      <mailto:iamutkarshtiwari at gmail.com>> wrote:
>>>>      >>> Hi Dave,
>>>>      >>>               Thanks for your appreciation. I think this
>>>>      feature isn't
>>>>      >>> intrusive also because if the user wants to ignore or 
>>>> cancel
>>>>      the save,
>>>>      >>> he can simply do so by pressing Esc key.
>>>>      >>>
>>>>      >>> Golden Rule- Giving the user a choice to do something but 
>>>> not
>>>>      force it.
>>>>      >>> ;)
>>>>      >>>
>>>>      >>> Thanks,
>>>>      >>> Utkarsh Tiwari
>>>>      >>>
>>>>      >>> On 4/4/16, Dave Crossland <dave at lab6.com
>>>>      <mailto:dave at lab6.com>> wrote:
>>>>      >>>> I think this is a good change/feature
>>>>      >>>>
>>>>      >> .
>>>>      >>
>>>>      >
>>>>      >
>>>> 
>>> 
>>> 
>> 
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20160513/179b4a1b/attachment.html>