[Sugar-devel] Browse: improve autocomplete list

James Cameron quozl at laptop.org
Fri Mar 4 18:15:05 EST 2016


The ticket is still untouched.  Have access problem?

On Fri, Mar 04, 2016 at 04:11:15PM +0530, Utkarsh Tiwari wrote:
> Hello everyone,
>                          I have pushed a final patch for this defect. With this
> PR ->
> 
> 1- Autocomplete list will now be able to display list of 20(max) entries which
> can be scrolled with both mouse pointer and Up/Down arrow keys.
> 2- URL is now placed below the Url title so that more text is visible.
> 3- The visible length of the list is of 5 entries so it won't also not
> superimpose over the OSK.
> 
> Please review it and let me know if any further modification are required. :)
> 
> Regards,
> Utkarsh Tiwari
> 
> On Wed, Mar 2, 2016 at 4:18 AM, Utkarsh Tiwari <[1]iamutkarshtiwari at gmail.com>
> wrote:
> 
>     Hello,
>              I did some modifications to the code so that the "URL" is
>     displayed below the title. I have also add the scroll feature to the search
>     results which could be scrolled with the mouse pointer but the problem here
>     is that the treeview is not scrolling with the 'key_up' and 'key_down'
>     buttons. Any hints on how to fix that?
> 
>     Regards,
>     Utkarsh Tiwari
> 
>     On Mon, Feb 29, 2016 at 4:49 AM, James Cameron <[2]quozl at laptop.org> wrote:
> 
>         On Sun, Feb 28, 2016 at 08:36:26PM +0530, Utkarsh Tiwari wrote:
>         > I would like to work on this bug ->
>         > [3]https://bugs.sugarlabs.org/ticket/4081
> 
>         Modify ticket, in the Action box click on accept, then Submit
>         changes.  As a result, the Bug Status should change.
> 
>         Later, if you stop work on the bug, set the Bug Status to something
>         other than Assigned or Accepted.
>        
>         > I went through the webtoolbar.py code and found that it uses cairo
>         > to draw the url suggestion dropdown list below the URL bar.
> 
>         Please use terminology consistent with the code; this is the
>         SearchWindow you are talking about, right?  Assuming yes.
>        
>         > Could anyone here provide some details about to integrate
>         > gtk.scrolledwindow or hints on how to get about it ?
> 
>         It looks like point 2 of the ticket is half done.  SearchWindow is
>         already a Gtk.TreeView inside a Gtk.ScrolledWindow inside a
>         Gtk.Window.  So you don't need to integrate Gtk.ScrolledWindow.
> 
>         Looking at point 1, "put the URL below the title", _search_create_view
>         in webtoolbar.py uses two standard Gtk.CellRendererText to build the
>         TreeView cells.  I agree with Manuq-three-years-ago that a custom
>         renderer may be needed.
> 
>         Look at our other custom renderers, e.g. src/sugar3/graphics/icon.py
>         and PreviewRenderer in src/jarabe/journal/iconview.py.
> 
>         Start Epiphany and use the feature.  Review the C code used in
>         Epiphany.
> 
>         Write a custom renderer.
>        
>         --
>         James Cameron
>         [4]http://quozl.netrek.org/
>         _______________________________________________
>         Sugar-devel mailing list
>         [5]Sugar-devel at lists.sugarlabs.org
>         [6]http://lists.sugarlabs.org/listinfo/sugar-devel
>    
> 
> References:
> 
> [1] mailto:iamutkarshtiwari at gmail.com
> [2] mailto:quozl at laptop.org
> [3] https://bugs.sugarlabs.org/ticket/4081
> [4] http://quozl.netrek.org/
> [5] mailto:Sugar-devel at lists.sugarlabs.org
> [6] http://lists.sugarlabs.org/listinfo/sugar-devel

-- 
James Cameron
http://quozl.netrek.org/


More information about the Sugar-devel mailing list