[Sugar-devel] Screenshot feature [GSoC Project]

[James Cameron]

I'm sorry, but I won't be accepting the patch as it stands now.  I'm
puzzled by your design.  Please work toward consensus before making
such changes.

Escape key handler must be put back.  Escape key must be enabled in
all modal dialogs; as a keyboard shortcut.  It is enabled for Help, My
Settings, View Source, and wireless password.

Enter key should be put back.  I don't see why this dialog shouldn't
accept enter key, in the same way that wireless password prompt does
now.  Have you even tested that?

The tick (check) and X icons; I don't like seeing them used in small
dialogs; the nearest equivalent is the wireless password prompt, which
doesn't have these icons.  But if others think the icons should be
used, to be consistent with Help, My Settings, and View Source, then
we should also extend it to the wireless password.

@Tony, please do some more research and testing of the Escape key
before giving such bad guidance; unless your purpose is to make these
changes to Sugar 0.98, you must be familiar with Sugar 0.108.

On Sat, Apr 09, 2016 at 04:19:00AM +0530, Utkarsh Tiwari wrote:
> Hi,
>      I have all these following listed inconsistencies as suggested ->
> 1- Esc key handler removed.
> 2- Enter key hander removed.
> 3- Now the screenshot can be saved only via save(check) toolbutton.
> 4- The screenshot alert can be 'not save' or 'cancelled' via cancel(X)
> toolbutton.
> 
> PR- https://github.com/sugarlabs/sugar/pull/675
> 
> Please update me if further modifications are required.
> 
> Thank you,
> Utkarsh Tiwari
> 
> On 4/8/16, Tony Anderson <tony_anderson at usa.net> wrote:
> > Hi,
> >
> > Consistency is very important to our users. Using Esc for this is unusual.
> >
> >
> > I have trouble following the screencast. It looks like you offer a check
> > and an x for the user. It also looks like an enter after providing the
> > title acts as
> > the check. The x appears to save the screenshot without changing the
> > title. The user doesn't appear to have an option not to save the
> > screenshot. Arguably the workflow would be to complete the task and then
> > go to the Journal to erase the unneeded screenshots. I have taken
> > screenshots and realized, for example, that the cursor was not on the
> > right toolbar item. For these, I would like to be able to have a 'no
> > save' option.
> >
> > Using Esc is not consistent with the way the rest of Sugar works and
> > doesn't seem needed since you offer an equivalent one-click option in
> > the alert/pop-up.
> >
> > Tony
> >
> > On 04/08/2016 02:07 PM, Utkarsh Tiwari wrote:
> >> Hi,
> >>      Here is the PR to the screenshot feature ->
> >> https://github.com/sugarlabs/sugar/pull/675
> >>
> >> Thank you,
> >> Utkarsh Tiwari
> >>
> >> On 4/4/16, Utkarsh Tiwari <iamutkarshtiwari at gmail.com> wrote:
> >>> Hi Dave,
> >>>               Thanks for your appreciation. I think this feature isn't
> >>> intrusive also because if the user wants to ignore or cancel the save,
> >>> he can simply do so by pressing Esc key.
> >>>
> >>> Golden Rule- Giving the user a choice to do something but not force it.
> >>> ;)
> >>>
> >>> Thanks,
> >>> Utkarsh Tiwari
> >>>
> >>> On 4/4/16, Dave Crossland <dave at lab6.com> wrote:
> >>>> I think this is a good change/feature
> >>>>
> >> .
> >>
> >
> >

-- 
James Cameron
http://quozl.netrek.org/