[Sugar-devel] adding gtk as a dependency on sugar-artwork

[Martin Abente]

Hello Sam, Gonzalo,

Now the new patch breaks it for Ubuntu 14.04, so I sent a new PR [1] which
doesn't break it (see my patch comment), please check it that works in
newer Fedora versions.

Regards,
Martin.

Refs:
1. https://github.com/sugarlabs/sugar-artwork/pull/68

On Thu, Jul 2, 2015 at 9:01 AM, Martin Abente <
martin.abente.lahaye at gmail.com> wrote:

> Will check today! Thanks Gonzalo and Sam!
>
> On Thu, Jul 2, 2015 at 7:29 AM, Gonzalo Odiard <godiard at sugarlabs.org>
> wrote:
>
>> Martin,
>> Are you ok with this new patch?
>>
>> Gonzalo
>>
>> On Thu, Jul 2, 2015 at 8:22 AM, Sam P. <sam at sam.today> wrote:
>>
>>> Patch:  https://github.com/sugarlabs/sugar-artwork/pull/67
>>>
>>> On Thu, Jul 2, 2015 at 9:15 PM Gonzalo Odiard <godiard at sugarlabs.org>
>>> wrote:
>>>
>>>> Great!
>>>>
>>>> On Thu, Jul 2, 2015 at 7:05 AM, Sam P. <sam at sam.today> wrote:
>>>>
>>>>> Hi Gonzalo,
>>>>>
>>>>> Testing without your patch it appears that the journal background
>>>>> didn't get broken - so most of the breakage must have been fixed later in
>>>>> the Gtk+ 3.17 cycle!
>>>>>
>>>>> Using your patch (the 1st one), it fixes the log tree view and the
>>>>> journal still works fine.  I will send a patch.
>>>>>
>>>>> Next time I'll try to be more up to date with how the Gtk+ release
>>>>> cycle works so that I'm not submiting sugar patches for Gtk+ bugs!
>>>>>
>>>>> Thanks,
>>>>> Sam
>>>>>
>>>>> On Thu, Jul 2, 2015 at 5:02 AM Gonzalo Odiard <godiard at sugarlabs.org>
>>>>> wrote:
>>>>>
>>>>>> If that don't work, should be good test:
>>>>>>
>>>>>> diff --git a/gtk3/theme/gtk-widgets.css.em
>>>>>> b/gtk3/theme/gtk-widgets.css.em
>>>>>> index 67e4e48..af87900 100644
>>>>>> --- a/gtk3/theme/gtk-widgets.css.em
>>>>>> +++ b/gtk3/theme/gtk-widgets.css.em
>>>>>> @@ -221,9 +221,18 @@ column-header .button:hover:active {
>>>>>>      border-width: 0px;
>>>>>>  }
>>>>>>
>>>>>> +GtkTreeView row:even {
>>>>>> +    background-color: @row_even;
>>>>>> +}
>>>>>> +
>>>>>>  GtkTreeView row:nth-child(even) {
>>>>>>      background-color: @row_even;
>>>>>>  }
>>>>>> +
>>>>>> +GtkTreeView row:odd {
>>>>>> +    background-color: @row_odd;
>>>>>> +}
>>>>>> +
>>>>>>  GtkTreeView row:nth-child(odd) {
>>>>>>      background-color: @row_odd;
>>>>>>  }
>>>>>>
>>>>>> On Wed, Jul 1, 2015 at 3:15 PM, Gonzalo Odiard <godiard at sugarlabs.org
>>>>>> > wrote:
>>>>>>
>>>>>>> Sam,
>>>>>>> I don't have rawhide installed to test, can you try adding rules for
>>>>>>> the two new and old ways, like here:
>>>>>>>
>>>>>>> diff --git a/gtk3/theme/gtk-widgets.css.em
>>>>>>> b/gtk3/theme/gtk-widgets.css.em
>>>>>>> index 67e4e48..d14bbfb 100644
>>>>>>> --- a/gtk3/theme/gtk-widgets.css.em
>>>>>>> +++ b/gtk3/theme/gtk-widgets.css.em
>>>>>>> @@ -221,10 +221,11 @@ column-header .button:hover:active {
>>>>>>>      border-width: 0px;
>>>>>>>  }
>>>>>>>
>>>>>>> -GtkTreeView row:nth-child(even) {
>>>>>>> +GtkTreeView row:even, GtkTreeView row:nth-child(even) {
>>>>>>>      background-color: @row_even;
>>>>>>>  }
>>>>>>> -GtkTreeView row:nth-child(odd) {
>>>>>>> +
>>>>>>> +GtkTreeView row:odd, GtkTreeView row:nth-child(odd) {
>>>>>>>      background-color: @row_odd;
>>>>>>>  }
>>>>>>>
>>>>>>> Works on Gtk 3.16, we need check if works on Gtk 3.18
>>>>>>>
>>>>>>> Gonzalo
>>>>>>>
>>>>>>> On Wed, Jul 1, 2015 at 1:29 PM, Martin Abente <
>>>>>>> martin.abente.lahaye at gmail.com> wrote:
>>>>>>>
>>>>>>>> From the tests I have done, I confirmed it is used in building
>>>>>>>> time, therefore I have reverted the patch until we can determine a better
>>>>>>>> solution.
>>>>>>>>
>>>>>>>> On Wed, Jul 1, 2015 at 12:05 PM, Martin Abente <
>>>>>>>> martin.abente.lahaye at gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Hello Sam,
>>>>>>>>>
>>>>>>>>> Different people reported an error while building sugar-artwork
>>>>>>>>> packages. The error is caused by this commit [1] which makes GTK a building
>>>>>>>>> requirement for sugar-artwork, but:
>>>>>>>>>
>>>>>>>>> a) if GTK version version is really used on building time, then
>>>>>>>>> the approach used in [1] is wrong, because the css would depend on the GTK
>>>>>>>>> version on the packager on something that is related to the final user
>>>>>>>>> runtime environment.
>>>>>>>>>
>>>>>>>>> b) if the GTK version is only used in running time, then we should
>>>>>>>>> make sure it does not become a building requirement.
>>>>>>>>>
>>>>>>>>> In either case, it does not seems to make sense to make it a
>>>>>>>>> dependency.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Martin.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Refs:
>>>>>>>>> 1.
>>>>>>>>> https://github.com/sugarlabs/sugar-artwork/commit/813a2d77d83284b031a4f2bd5775b9f82b12846e
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Gonzalo Odiard
>>>>>>>
>>>>>>> SugarLabs - Software [for | by] children learning
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Gonzalo Odiard
>>>>>>
>>>>>> SugarLabs - Software [for | by] children learning
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Gonzalo Odiard
>>>>
>>>> SugarLabs - Software [for | by] children learning
>>>>
>>>
>>
>>
>> --
>> Gonzalo Odiard
>>
>> SugarLabs - Software [for | by] children learning
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20150702/ce46fdf4/attachment-0001.html>