[Sugar-devel] sugar and python-dateutil in Fedora 22

[Peter Robinson]

On Mon, Jan 19, 2015 at 3:15 AM, James Cameron <quozl at laptop.org> wrote:
> On Mon, Jan 19, 2015 at 02:43:10AM +0000, Peter Robinson wrote:
>> The sugar toolkit (for both gtk2 and gtk3) uses python-dateutil and
>> they're rebasing it from 1.5 to 2.x, would it be possible for someone
>> to review to see if there's any changes needed in the code please?
>
> Checked on Fedora 20, no issues seen.
>
> Method #1, install package python-dateutil-2.2-1.fc22.noarch.rpm,
> restart Sugar, test Sugar desktop functions, test my settings, test
> journal, test several activities.
>
> Method #2, static analysis; the only use in sugar-toolkit-gtk{,3} is
> in a private function _extract_modification_time in
> src/sugar3/activity/i18n.py which is for PO file revision date
> parsing, and there's no caller of the function in sugar,
> sugar-toolkit-gtk3, or the activity set in my builds, or any of the
> .py files in /usr/lib/.  (It might be removed as unused?)
>
> Method #3, manual checking of the feature used by the function, with
> two of the revision dates in the Record activity PO files, against 2.x;

Hi James, thanks for the update. So if I read the above correctly
there's only one function that uses it in the toolkits, it works fine
with the new version, but there doesn't appear to be any Activity that
actually uses the function?

Peter