[Sugar-devel] [SoaS] Testing Sugar Activities Fedora-Live-SoaS-i686-21_Beta-4

[Sebastian Silva]

So ask Sebastian Dzallas why he removed my contribution!
Sebastian Silva
http://somosazucar.org/



2014-11-25 7:50 GMT-05:00 Gonzalo Odiard <godiard at sugarlabs.org>:
> Yes, but that is what this patch do, right?
>
> http://pkgs.fedoraproject.org/cgit/sugar-speak.git/commit/?id=438f3796a85556873c5e45d6ba01ccfa558ca198
>
> On Tue, Nov 25, 2014 at 9:47 AM, Sebastian Silva <sebastian at somosazucar.org>
> wrote:
>>
>> btw it's sneaky to remove funcionality in a .spec file, no?
>> Sebastian Silva
>> http://somosazucar.org/
>>
>>
>>
>> 2014-11-25 7:46 GMT-05:00 Sebastian Silva <sebastian at somosazucar.org>:
>> > I added Alice and Sara (spanish bot) but was not aware it was removed.
>> > It certainly runs quite well in spanish XO1, as deployed in Peru.
>> > I was not aware of responsible for the removed functionality nor was I
>> > aware of any bugs related to it or performance.
>> >
>> > Please add it back
>> > Sebastian Silva
>> > http://somosazucar.org/
>> >
>> >
>> >
>> > 2014-11-25 7:17 GMT-05:00 Peter Robinson <pbrobinson at gmail.com>:
>> >> On Tue, Nov 25, 2014 at 12:05 PM, Gonzalo Odiard
>> >> <godiard at sugarlabs.org> wrote:
>> >>>
>> >>>
>> >>> On Tue, Nov 25, 2014 at 8:28 AM, Peter Robinson <pbrobinson at gmail.com>
>> >>> wrote:
>> >>>>
>> >>>> On Mon, Nov 24, 2014 at 4:10 PM, Gonzalo Odiard
>> >>>> <godiard at sugarlabs.org>
>> >>>> wrote:
>> >>>> > You find it. I don't know why the bot directory should be deleted.
>> >>>> > I cc to peter, who maintain the rpm.
>> >>>>
>> >>>> It goes back long before I was  the maintainer and was previously
>> >>>> working. The question is what does it do, and why when Speak has been
>> >>>> working for years does it suddenly break.
>> >>>>
>> >>>>
>> >>>>
>> >>>> http://pkgs.fedoraproject.org/cgit/sugar-speak.git/commit/?id=438f3796a85556873c5e45d6ba01ccfa558ca198
>> >>>
>> >>>
>> >>> That patch removes the bots functionality. Looks like was done to make
>> >>> the
>> >>> activity
>> >>> work on systems with small memory (XO-1, probably)
>> >>> cc is Sebastian, the patch author, to check if this is still needed.
>> >>>
>> >>> I see 438f3796a85556873c5e45d6ba01ccfa558ca198 removes the bots
>> >>> directory,
>> >>> _and_ apply the patch  sugar-speak-no-aiml.patch, to remove the need
>> >>> of the
>> >>> bots data,
>> >>> but right now, we are not applying that patch, then would be better
>> >>> add the
>> >>> bot directory again.
>> >>
>> >> I suspect it was sufficiently long ago that Seb won't remember the
>> >> reason.
>> >>
>> >> Ultimately we need to just sort it out here.
>> >>
>> >> Peter
>
>
>
>
> --
> Gonzalo Odiard
>
> SugarLabs - Software for children learning