[Sugar-devel] Gtk 3.10 icon size regression

[Daniel Narvaez]

On 13 January 2014 21:13, Manuel Quiñones <manuq at laptop.org> wrote:

> 2014/1/11 Daniel Narvaez <dwnarvaez at gmail.com>:
> > Ok, we looked more into this and it's an horrible, horrible mess. Several
> > activities are using Gtk.IconSize, often just passing it to Gtk.Image.
> Here
> > is the best possible plan I can think of:
>
> I agree with the whole plan.
>
> >
> > - Change sugar and sugar-toolkit-gtk3 to never use Gtk.IconSize
> explicitly.
> > Just use pixels, the sizes stuff is half deprecated and of very little
> use.
> > - Set the proper pixel_size on the toolbutton image.
>
> I'll fix sugar and sugar-toolkit-gtk3 basing on Ignacio work
>
> > Hacks to help backward compatibility
> >
> > - Register sugar specific sizes (LARGE_TOOLBAR, MENU) with the deprecated
> > Gtk.icon_size_register function.
> > - Overwrite Gtk.IconSize.* with the sugar specific sizes. This will only
> > work at python level, but should help a lot with activities that uses
> them.
>
> I came up with this:
> https://github.com/manuq/sugar-toolkit-gtk3/pull/4/files
>

Thanks! I commented there. Not sure if it was intentional but this was a
pull request to your own repo, not to upstream.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140114/5ba174dc/attachment.html>