[Sugar-devel] Gtk 3.10 icon size regression

[Gonzalo Odiard]

Sadly, have more sense set icon_size than pixel_size, right?
(More in the context of multiple pixels resolutions, like we have with the
xo and the desktop)

I think is better fix Icon to get the parameter and set the pixel_size,
and not do all the modifications Ignacio found.
In fact, Icon is sugar toolkit code, and do other tricks,
then we don't need deprecate the parameter.

Gonzalo



On Mon, Jan 13, 2014 at 10:56 AM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:

> pixel_size with style.STANDARD_ICON_SIZE (etc).
>
>
> On 13 January 2014 14:55, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
>
>> For Icon pixel_size.
>>
>>
>> On 13 January 2014 14:31, Gonzalo Odiard <godiard at sugarlabs.org> wrote:
>>
>>> What should be used instead of icon_size?
>>>
>>> Gonzalo
>>>
>>>
>>> On Sat, Jan 11, 2014 at 12:43 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>>
>>>> Ok, we looked more into this and it's an horrible, horrible mess.
>>>> Several activities are using Gtk.IconSize, often just passing it to
>>>> Gtk.Image. Here is the best possible plan I can think of:
>>>>
>>>> - Change sugar and sugar-toolkit-gtk3 to never use Gtk.IconSize
>>>> explicitly. Just use pixels, the sizes stuff is half deprecated and of very
>>>> little use.
>>>> - Set the proper pixel_size on the toolbutton image.
>>>>
>>>> Hacks to help backward compatibility
>>>>
>>>> - Register sugar specific sizes (LARGE_TOOLBAR, MENU) with the
>>>> deprecated Gtk.icon_size_register function.
>>>> - Overwrite Gtk.IconSize.* with the sugar specific sizes. This will
>>>> only work at python level, but should help a lot with activities that uses
>>>> them.
>>>>
>>>> Cleanup
>>>>
>>>> - Drop sizes from settings.ini
>>>> - Deprecate Icon's icon_size property.
>>>> - Suggest that activity authors never use Gtk.IconSize.
>>>>
>>>> I'm not sure this will fix everything, but should at least cover the
>>>> large majority of the issues.
>>>>
>>>> _______________________________________________
>>>> Sugar-devel mailing list
>>>> Sugar-devel at lists.sugarlabs.org
>>>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>>>
>>>>
>>>
>>>
>>> --
>>> Gonzalo Odiard
>>>
>>> SugarLabs - Learning Software for children
>>>
>>
>>
>>
>> --
>> Daniel Narvaez
>>
>
>
>
> --
> Daniel Narvaez
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>


-- 
Gonzalo Odiard

SugarLabs - Learning Software for children
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140113/e741afb1/attachment.html>