[Sugar-devel] [DESIGN] Journal time filter (was Re: Fwd: GCI task, Ticket #3026)

[Emil Dudev]

I updated my patch to use a ComboBox.
Same link: https://github.com/edudev/sugar/compare/ticket3026.patch

Since not using a slider, the class I initially create is unneeded. The
only thing I don't like in the code is the count of the global variables...

Not sure how to tweak the time spans.

Emil Dudev


On Fri, Jan 3, 2014 at 10:50 PM, Manuel Quiñones <manuq at laptop.org> wrote:

> 2013/12/4 Daniel Narvaez <dwnarvaez at gmail.com>:
> > The tag seems to be helpful to get designers attention :)
> >
> > On Tuesday, 3 December 2013, Walter Bender wrote:
> >>
> >> Emil's code works well; the question to me is one of design. He
> >> replaced the comboboxes with a slider. I wonder if perhaps a palette
> >> (like the one Gonzalo developed for Fonts) might be better. We also
> >> may want to tweak the actually times made available. But Emil's patch
> >> does capture the spirit of what we are trying to accomplish.
>
> Good point Walter.  At first glance, I think the slider does not fit
> the model.  I can't see why:
>
> 1. this week < 2. last week < 3. this month
>
> Having a journal entry made today, I can see it in 1. and 3, and not in 2.
>
> So I think a combo, like it is now, fits better.
>
> Side note: I have applied the patch
> (https://github.com/edudev/sugar/compare/ticket3026.patch), but I'm
> having a hard time testing it with a new sugar build, just because i
> don't have old journal entries.  So I guess I'll have to create mock
> entries for testing this.  Has anyone did this before?  Or do we have
> a sample datastore for testing?
>
> --
> .. manuq ..
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140112/e8c809e9/attachment.html>