[Sugar-devel] Gtk 3.10 icon size regression

[Ignacio Rodríguez]

We need to test it on "old" versions.
I think it works on all versions :)

2014/1/10, Daniel Narvaez <dwnarvaez at gmail.com>:
> Whoa scary amount of changes! I hope it might be possible to reduce them,
> for example we could change Icon to handle icon_size in a backward
> compatible way.
>
> Though I think we really need to see a grep on Gonzalo collection of all
> the activities, to be able to decide the best strategy.
>
> Thanks again for working in this.
>
> On Friday, 10 January 2014, Ignacio Rodríguez wrote:
>
>> > I think we are safe in activities.  I will look at Browse.
>>
>> No, this is a "global" problem, just now, I'm removing all IconSizes from
>> core.
>>
>> 2014/1/10, Manuel Quiñones <manuq at laptop.org <javascript:;>>:
>> > Thanks Ignacio and Daniel for taking action.
>> >
>> > I think we are safe in activities.  I will look at Browse.
>> >
>> >
>> > 2014/1/10 Ignacio Rodríguez <nachoel01 at gmail.com>
>> >
>> >> Just now:
>> >>
>> >> [image: Imágenes integradas 1]
>> >>
>> >> Working on bugs.
>> >> BTW, gtk2 activities aren't this problem.
>> >> Saludos.
>> >> Ignacio Rodríguez
>> >>
>> >>
>> >> 2014/1/10 Gonzalo Odiard <godiard at sugarlabs.org>
>> >>
>> >>>
>> >>>> For ToolButton the fix should be easy, we just make the Icon
>> >>>> STANDARD_ICON_SIZE. But there might be other cases where these
>> >>>> properties
>> >>>> was used. Hopefully activities are not using Gtk.IconSize
>> >>>> directly...
>> >>>> Perhaps you could grep? :)
>> >>>>
>> >>>>
>> >>> I can search later. Anyway should be only activities ported to gtk3.
>> >>>
>> >>> Gonzalo
>> >>>
>> >>>
>> >>>>
>> >>>>
>> >>>> On 10 January 2014 16:51, Gonzalo Odiard <godiard at sugarlabs.org>
>> wrote:
>> >>>>
>> >>>>> I don't understand what is the problem or the use case. Could you
>> >>>>> explain?
>> >>>>>
>> >>>>> Gonzalo
>> >>>>>
>> >>>>>
>> >>>>> On Fri, Jan 10, 2014 at 12:43 PM, Daniel Narvaez
>> >>>>> <dwnarvaez at gmail.com>wrote:
>> >>>>>
>> >>>>>> Hi,
>> >>>>>>
>> >>>>>> so, it looks like the GtkSettings icon sizes are ignored with 3.10
>> >>>>>> (intentionally deprecated). As far as I can tell the default sizes
>> are
>> >>>>>> now
>> >>>>>> just hardcoded. So I think the only way is to pass the size
>> explicitly
>> >>>>>> to
>> >>>>>> Icon. Ignacio is trying to do that in ToolButton, I do wonder if
>> there
>> >>>>>> are
>> >>>>>> other cases, especially in activities.
>> >>>>>>
>> >>>>>> --
>> >>>>>> Daniel Narvaez
>> >>>>>>
>> >>>>>> _______________________________________________
>> >>>>>> Sugar-devel mailing list
>> >>>>>> Sugar-devel at lists.sugarlabs.org
>> >>>>>> http://lists.sugarlabs.org/listinfo/sugar-devel
>> >>>>>>
>> >>>>>>
>> >>>>>
>> >>>>>
>> >>>>> --
>> >>>>> Gonzalo Odiard
>> >>>>>
>> >>>>> SugarLabs - Learning Software for children
>> >>>>>
>> >>>>
>> >>>>
>> >>>>
>> >>>> --
>> >>>> Daniel Narvaez
>> >>>>
>> >>>> _______________________________________________
>> >>>> Sugar-devel mailing list
>> >>>> Sugar-devel at lists.sugarlabs.org
>> >>>> http://lists.sugarlabs.org/listinfo/sugar-devel
>> >>>>
>> >>>>
>> >>>
>> >>>
>> >>> --
>> >>> Gonzalo Odiard
>> >>>
>> >>> SugarLabs - Learning Software for children
>> >>>
>> >>> _______________________________________________
>> >>> Sugar-devel mailing list
>> >>> Sugar-devel at lists.sugarlabs.org
>> >>> http://lists.sugarlabs.org/listinfo/sugar-devel
>> >>>
>> >>>
>> >>
>> >> _______________________________________________
>> >> Sugar-devel mailing list
>> >> --
>> Saludos.
>> Ignacio Rodríguez
>>
>
>
> --
> Daniel Narvaez
>


-- 
Saludos.
Ignacio Rodríguez