[Sugar-devel] [DESIGN] Add style.MENU_WIDTH_CHARS
Manuel Quiñones
manuq at laptop.org
Tue Jan 7 08:52:48 EST 2014
2013/12/20 Ignacio Rodríguez <nachoel01 at gmail.com>:
> Hi!
> I make a simple patch, for set MENU_WIDTH_CHARS, by default is 60 :)
> I modified the files where max_width_chars appear
>
> Patch's attached.
Hi Ignacio,
nothing to discuss design wise. It is a nice refactor. The first
patch "add MENU_WIDTH_CHARS to widgets" looks fine, please send a pull
requiest. The second looks wrong to me, the value is 50, not 60, and
InlineAlert is not a menu.
Thanks,
--
.. manuq ..
More information about the Sugar-devel
mailing list