[Sugar-devel] About adding toolkit_type and toolkit_version options to bundles

[Daniel Narvaez]

Hello,

parsing code to find that out is such an hack...

Anyway, I explained in the other thread what I think is the right way to do
this in the future and I'm content with that. As long as

- the hack is done properly (no sync file loading)
- I'm not the one having to review the patch (too complicated to make it
really solid)
- there is comment explaining that the proper way to do it would be to look
at the exec field

Then I'm fine with it landing.

On Monday, 17 February 2014, Gonzalo Odiard <godiard at sugarlabs.org> wrote:

> This is a reply to @dnarvaez comment
>
>
> https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/104#issuecomment-35170356
>
> The addition of a field to identify gtk2/gtk3 activities,
> was proposed as a solution to View Source issue [1]
>
> I think there are two other easier ways to solve this particular issue:
>
> * check the setup.py file
> * check the file with the startup class (view source already identify the
> file, see [2]
>
> Making changes to the activity.info file usually take a long time
> to get included in a significant number of activities,
> if we can solve it in the code is better in my opinion.
>
> --
> Gonzalo Odiard
>
> SugarLabs - Learning Software for children
>
> [1]
> https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/104#issuecomment-35170356
> [2]
> https://github.com/sugarlabs/sugar/blob/master/src/jarabe/view/viewsource.py#L205
>


-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140217/93b5d670/attachment.html>