[Sugar-devel] Pull requests + buildbot

[Gonzalo Odiard]

I asked because I received the mails yesterday for every pull request,
and then when was opened and closed,
but not when a build failed. Even in "Test breaking build (#332)"
May be is only received by who sent the pr?

Gonzalo


On Mon, Apr 7, 2014 at 6:23 AM, Daniel Narvaez <dwnarvaez at gmail.com> wrote:

> Did you see the "details" link? It's the same link we receive by email.
>
>
> On Monday, 7 April 2014, Gonzalo Odiard <godiard at sugarlabs.org> wrote:
>
>> Nice trick. Is possible add a comment with the build result,
>> then we receive a mail? (Or at least in the fail case)
>>
>> Gonzalo
>>
>>
>> On Sun, Apr 6, 2014 at 6:20 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>
>>> It starts a build whenever a pr is opened or reopened, while it's
>>> building it shows that there is a build pending, then it changes the status
>>> to success/failure. It also starts a new build if commits are added or
>>> changed.
>>>
>>>
>>> On 6 April 2014 21:17, Manuel Quiñones <manuq at laptop.org> wrote:
>>>
>>>> 2014-04-05 21:51 GMT-03:00 Daniel Narvaez <dwnarvaez at gmail.com>:
>>>> > Hey,
>>>> >
>>>> > I have finally setup integration between pull requests and buildbot.
>>>> >
>>>> > When you push a pull request buildbot will trigger a build and update
>>>> the
>>>> > github UI to indicate success or failure. The idea is that we should
>>>> not
>>>> > normally merge a pull request unless the build was successful.
>>>> >
>>>> > You can open the build page by clicking on the "details" link. If the
>>>> build
>>>> > failed for reasons which are not related to the patches, you can use
>>>> the
>>>> > "Rebuild" button to retry it.
>>>> >
>>>> > The integration is done with a very simple node server
>>>> > https://github.com/sugarlabs/sugar-gitbot/blob/master/app.js
>>>> > I don't expect it to be particularly solid yet, so if you run into
>>>> any issue
>>>> > please let me know!
>>>>
>>>> Great work! I see it is running well.  So it closes the PR while
>>>> checking and then if check succeeds reopens it again?
>>>>
>>>> --
>>>> .. manuq ..
>>>>
>>>
>>>
>>>
>>> --
>>> Daniel Narvaez
>>>
>>> _______________________________________________
>>> Sugar-devel mailing list
>>> Sugar-devel at lists.sugarlabs.org
>>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>>
>>>
>>
>>
>> --
>> Gonzalo Odiard
>>
>> SugarLabs - Software for children learning
>>
>
>
> --
> Daniel Narvaez
>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>


-- 
Gonzalo Odiard

SugarLabs - Software for children learning
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140407/b516b672/attachment-0001.html>