[Sugar-devel] About using networkmanager with introspection

[Gonzalo Odiard]

On Fri, Apr 4, 2014 at 5:24 PM, James Cameron <quozl at laptop.org> wrote:

> It is so irritating that to review patches to Sugar one has to click
> on the link in the mail, which doesn't even get you to the patch, but
> instead takes you to a page you have to click twice on to see the
> code.  And since the pages are SSL over HTTP, the time to connect can
> be considerable.  This really favours developers with low latency
> internet.  ;-}
>
>
I know, modern times....

manuq taught me a useful github trick:

when you have a link like https://github.com/sugarlabs/sugar/pull/328
you can add .patch or .diff to the url
and get a clean patch
can be useful for you I imagine.



> On Fri, Apr 04, 2014 at 12:04:25PM -0300, Gonzalo Odiard wrote:
> > I was exploring use the gi api for network manager,
> > instead of our old dbus api.
> > This was not done when we ported sugar to gtk3.
> >
> > I have sent two pr [1] and [2] with the easy parts.
>
> Reviewed-by: James Cameron <quozl at laptop.org>
>
> It is so much simpler.  I like it, please continue.
>

Thanks.

>
> It reminds me of how silly the dbus api was when I first saw it.
>
> > The last piece missing is jarabe/model/network.py and is a big
> > piece. I started to change it, but look like a big project,  and
> > will need a lot more work and extensive testing.
>
> Yes, it will be some considerable work, but as you know, it can be
> broken into short periods of editing.  When I have to break such a
> conversion into multiple sessions, I add more careful methods to check
> the changes before commit.
>
>
I agree. Is a good opportunity to add testing to our networking code.


> --
> James Cameron
> http://quozl.linux.org.au/
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>



-- 
Gonzalo Odiard

SugarLabs - Software for children learning
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140404/8191bc0c/attachment.html>