[Sugar-devel] service_name and bundle_id... again

[Alan Jhonn Aguiar Schwyn]

I think that we must check the GTK-2 version of all activities and fix thatproblem.Gonzalo: you have the list of activities that need be fixed?

Date: Wed, 30 Oct 2013 15:41:56 -0200
From: gonzalo at laptop.org
To: manuq at laptop.org
CC: dwnarvaez at gmail.com; sugar-devel at lists.sugarlabs.org
Subject: Re: [Sugar-devel] service_name and bundle_id... again


Oh, good Gonzalo, this is the bug to solve then.  Your patch is in the


correct direction, but allows GTK3 activities to use service_name,

which I don't think is correct.  The fix should allow only GTK2

activities to use service_name, and log a deprecation warning message,

as you did.



I don't see your point. 
Look at the code. activitybundle.py do not have logic to recognize gtk2 or gtk3activities. The patch is simple, why look for a more complicate logic,
only to avoid new activities using service_name instead of bundle_id?
We have a problem with old activities stopping working, not with new activities. 
Gonzalo

 
Thanks,



--

.. manuq ..




_______________________________________________
Sugar-devel mailing list
Sugar-devel at lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20131030/a11c4d2c/attachment.html>