[Sugar-devel] service_name and bundle_id... again

[Gonzalo Odiard]

On Wed, Oct 30, 2013 at 1:51 PM, Manuel Quiñones <manuq at laptop.org> wrote:

> Hi,
>
> 2013/10/30 Daniel Narvaez <dwnarvaez at gmail.com>:
> > This breaks gtk2 activities right? I think that should be considered a
> bug
> > and thus we should take the patch (I have not reviewed it). I would add a
> > comment though so that when we will finally drop gtk2 support we will
> remove
> > this too.
>
> First of all, GTK2 activities should use sugar-toolkit, not
> sugar-toolkit-gtk3 .
>

Wait. The problem is not gtk2 activities using sugar-toolkit-gtk3.

The problem is, sugar is using sugar-toolkit-gtk3 to read the activity.infofile
on old activities. Then, that activities can't start.

We know service_name is deprecated. Also the old style toolbars,
but we support activities using old toolbars.

In the end, is a problem for the deployments, and we don't lost anything
adding the workaround.
You know I worked a lot updating core activities to solve this issue,
but from the release of sugar 0.98 until today,
I saw many problems related with this issue.
Sadly, not all the activities are in ASLO, and breaking them without a real
benefit
is not a good strategy.

Gonzalo



>
> So this is not a bug.  The 'service_name' is deprecated since six
> years ago, in old Sugar v0.70.2.  I couldn't find release notes, but
> that's what git log says.  When we did sugar-toolkit-gtk3 for the GTK3
> port, we did a cleanup of deprecated API. Was about time.
>
> http://wiki.sugarlabs.org/go/Features/GTK3/Porting#Cleanup.2C_adopt_to_API_changes_in_sugar-toolkit-gtk3
>
> By Sugar 0.84 - 0.86, all the core activities updated their activity.info.
>
> In Sugar 0.90, deprecation warning messages were added:
> http://wiki.sugarlabs.org/go/0.90/Notes#API
>
> I think these activities should just update their activity.info .
>
>
> >
> > On Wednesday, 30 October 2013, Gonzalo Odiard wrote:
> >>
> >> Today I received this mail from Esteban Arias in Uruguay:
> >>
> >> "....
> >> Cuando sugar cambió el toolbar, o cuando se pasó a gtk3, se mantuvo
> >> compatibilidad hacia atrás.
> >> Pero al pasar a sugar 0.98 varias de las actividades dejaron de
> funcionar
> >> por tener service_name en lugar de bundle_id enel activity.info.
> >> Existe alguno parche o alguna solución para evitar cambiar todos los
> >> activity.info de las actividades?
> >> ....
> >> "
> >> Translation:
> >> "When sugar changed the toolbar, or when changed to gtk3, background
> >> compatibility
> >> was maintained. But with the change to 0.98 several activities stoped
> >> working because
> >> have service_name instead of bundle_id in activity.info.
> >> There are a patch or fix to avoid change the activity.info file in
> every
> >> activity?"
> >>
> >> Similar mails reporting errors in activities, and finally found the
> >> problem is related to this
> >> change are received regularly in support mailing lists as iaep or
> >> support-gang.
> >>
> >> I wanted try what is needed change to make that activities work, and the
> >> change is really small. Attached is a patch to sugar-toolkit-gtk3. From
> my
> >> part I think we have broken
> >> compatibility without a good reason in this case, and should be solved.
> >>
> >> What you think about include it  in Sugar?
> >>
> >> Gonzalo
> >
> >
> >
> > --
> > Daniel Narvaez
> >
> >
> > _______________________________________________
> > Sugar-devel mailing list
> > Sugar-devel at lists.sugarlabs.org
> > http://lists.sugarlabs.org/listinfo/sugar-devel
> >
>
>
>
> --
> .. manuq ..
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20131030/a3ff86b2/attachment.html>