[Sugar-devel] service_name and bundle_id... again

[Daniel Narvaez]

For the comment I mean just something like "This is necessary only to keep
gtk2 activities working". It's not obvious unless you know the whole
history of those properties.

On Wednesday, 30 October 2013, Gonzalo Odiard wrote:

> Yes, all the affected activities are gtk2 activities.
>
> We removed the code to support service_name in gtk3,
> and did not affected the old activities until we ported sugar to gtk3.
>
> About the comment you suggest, do we have any convention for this case?
>
> Gonzalo
>
>
> On Wed, Oct 30, 2013 at 12:44 PM, Daniel Narvaez <dwnarvaez at gmail.com<javascript:_e({}, 'cvml', 'dwnarvaez at gmail.com');>
> > wrote:
>
>> This breaks gtk2 activities right? I think that should be considered a
>> bug and thus we should take the patch (I have not reviewed it). I would add
>> a comment though so that when we will finally drop gtk2 support we will
>> remove this too.
>>
>> On Wednesday, 30 October 2013, Gonzalo Odiard wrote:
>>
>>> Today I received this mail from Esteban Arias in Uruguay:
>>>
>>> "....
>>> Cuando sugar cambió el toolbar, o cuando se pasó a gtk3, se mantuvo
>>> compatibilidad hacia atrás.
>>> Pero al pasar a sugar 0.98 varias de las actividades dejaron de
>>> funcionar por tener *service_name* en lugar de* bundle_id *enel
>>> activity.info.
>>> Existe alguno parche o alguna solución para evitar cambiar todos los
>>> activity.info de las actividades?
>>> ....
>>> "
>>> Translation:
>>> "When sugar changed the toolbar, or when changed to gtk3, background
>>> compatibility
>>> was maintained. But with the change to 0.98 several activities stoped
>>> working because
>>> have service_name instead of bundle_id in activity.info.
>>> There are a patch or fix to avoid change the activity.info file in
>>> every activity?"
>>>
>>> Similar mails reporting errors in activities, and finally found the
>>> problem is related to this
>>> change are received regularly in support mailing lists as iaep or
>>> support-gang.
>>>
>>> I wanted try what is needed change to make that activities work, and the
>>> change is really small. Attached is a patch to sugar-toolkit-gtk3. From my
>>> part I think we have broken
>>> compatibility without a good reason in this case, and should be solved.
>>>
>>> What you think about include it  in Sugar?
>>>
>>> Gonzalo
>>>
>>
>>
>> --
>> Daniel Narvaez
>>
>>
>

-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20131030/fc6cbfdb/attachment-0001.html>