[Sugar-devel] Browse feature review for Google Code In - Clear URL bar when Escape is pressed.

[Gonzalo Odiard]

cc: manuq, maintainer of Browse


On Mon, Nov 18, 2013 at 4:37 PM, Walter Bender <walter.bender at gmail.com>wrote:

> On Mon, Nov 18, 2013 at 2:23 PM, Sai Vineet <saivineet89 at gmail.com> wrote:
> > I've attached the patch. It is a one liner.
> > The mentors in GCI, namely Walter Bender and Gonzalo Odiard, told me that
> > this review may take time, so I should move on the other tasks after
> > unclaiming this task.
> >
> > Please review this fast. Thank you!
> >
> > _______________________________________________
> > Sugar-devel mailing list
> > Sugar-devel at lists.sugarlabs.org
> > http://lists.sugarlabs.org/listinfo/sugar-devel
> >
>
> I've tested the patch: it works. The question is whether or not we
> like the behavior. The relevant ticket is
> http://bugs.sugarlabs.org/ticket/3954
> What happens is that escape will both close the suggestions drop-down
> and clear the entry. It may be better to do it in two steps.
>
> -walter
>
> --
> Walter Bender
> Sugar Labs
> http://www.sugarlabs.org
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20131118/54c3a30f/attachment-0001.html>