[Sugar-devel] Build broken, pep8

Daniel Narvaez dwnarvaez at gmail.com
Sat May 18 13:18:27 EDT 2013


Yeah. The pep8 --exclude patch is not very good, so I used pyflakes8.


On 18 May 2013 19:16, Manuel Quiñones <manuq at laptop.org> wrote:

> Thanks for the fix.  I see that flake8 is the one that was merged.  Good.
>
> 2013/5/18 Daniel Narvaez <dwnarvaez at gmail.com>:
> > https://github.com/sugarlabs/sugar/pull/66
> >
> > A quick review would be appreciated, to unbreak the build.
> >
> >
> > On 17 May 2013 21:41, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
> >>
> >>
> >>
> http://buildbot.sugarlabs.org/builders/raring-amd64-quick/builds/9/steps/shell_3/logs/stdio
> >>
> >> config.py is autogenerated, so lines can be arbitrary long.
> >>
> >> Perhaps the simplest fix it just to use --exclude.
> >> We could also consider switching to flake8 to run both pyflakes and pep8
> >> and be able to skip certain lines.
> >> Maybe it's overkill though, since we are not needing that feature other
> >> than for this case.
> >>  (I sort of like the asserts. To silence pyflake when necessary.)
> >>
> >>
> >> --
> >> Daniel Narvaez
> >>
> >
> >
> >
> > --
> > Daniel Narvaez
> >
> > _______________________________________________
> > Sugar-devel mailing list
> > Sugar-devel at lists.sugarlabs.org
> > http://lists.sugarlabs.org/listinfo/sugar-devel
> >
>
>
>
> --
> .. manuq ..
>



-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130518/328d6863/attachment.html>


More information about the Sugar-devel mailing list