[Sugar-devel] Automated pyflakes checking

[Daniel Narvaez]

On 8 May 2013 06:02, William Orr <will at worrbase.com> wrote:

>
> I've done some initial work on both sugar and sugar-toolkit-gtk3 with
> respect to PEP8. I've also added support for PEP8 in make check for both
> packages.
>
> Pull requests are here:
> https://github.com/sugarlabs/**sugar-toolkit-gtk3/pull/25<https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/25>
> https://github.com/sugarlabs/**sugar/pull/49<https://github.com/sugarlabs/sugar/pull/49>
>
> Let me know if I need to make any changes.
>

Awesome! Thanks for working on this!

I didn't go through all the changes yet, but I have one general concern.
You have disabled E501 (line too long), which would be fine as an
intermediate step, though you seem to be regressing line length when fixing
the other issues. Perhaps it make sense to do the E501 changes together so
that we avoid regressions?

If you end up reworking the patches it might also make sense to split them
up a bit more (even arbitrarily) just to review/land more gradually and
diminish a bit the risk of conflicts etc. I don't expect the review to be
particularly complicated, though there are a few odd cases with line
continuations that we will need to check/discuss/tweak.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130508/21f779fa/attachment-0001.html>