[Sugar-devel] [sugar PATCH] sl#3833: Now, the palettes appear fine in the bottom frame-tray.

[Ajay Garg]

On Mon, Mar 11, 2013 at 6:11 PM, Manuel Quiñones <manuq at laptop.org> wrote:

> 2013/3/11 Manuel Quiñones <manuq at laptop.org>:
> > Hi Ajay, thanks for keep working on this one.
> >
> > 2013/3/6 Ajay Garg <ajay at activitycentral.com>:
> >> The solution has been build upon the "no-caching" solution provided by
> erikos at
> >> http://bugs.sugarlabs.org/ticket/4419#comment:4
> >>
> >> Theerafter, the cause of
> http://bugs.sugarlabs.org/attachment/ticket/3833/Screenshot%20of%20_Journal_.png
> >> is not taking "style.GRID_CELL_SIZE" into account, when calucating the
> alignments for the palettes.
> >>
> >> I will have to thank manuq a great deal, for his comment
> http://bugs.sugarlabs.org/ticket/3833#comment:11,
> >> which helped me debug the real issue.
> >> In particular, his observation that the "landscape"-mode-obscurity
> occurs only in one of the erikos' solutions;
> >> while the "portrait-mode-obscurity" occurs only in both of erikos's
> solutions.
> >>
> >> Finally, this patch provides the no-obscurity solution for all cases :)
> >
> > I see issues with your patch:
> >
> > 1. I can't bring the palettes of device icons (the ones at the bottom
> > right of the frame) with the screen rotated in portrait mode.
> >
> > 2. after rotation I see the shutdown/reboot palette (icon on the right
> > side of the frame) wrongly placed in landscape mode.  See screenshot:
> > http://bugs.sugarlabs.org/attachment/ticket/3833/sc.png
> >
> > So it doesn't pass the TestCase:
> > http://bugs.sugarlabs.org/ticket/3833#comment:1
>
> Sorry, I was testing badly.  Your patch does solve all the issues.
>


Seems we both hit the "Send" button at the same time :)
Thanks for the prompt clarification !!





> With the improvements Simon ask for (long lines + improved commit
> message), I'm +1 to push.  Thanks!
>

My pleasure  :)








>
> --
> .. manuq ..
>



-- 
Regards,

Ajay Garg
Dextrose Developer
Activity Central: http://activitycentral.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130311/f056cc34/attachment.html>