[Sugar-devel] [sugar PATCH] sl#3833: Now, the palettes appear fine in the bottom frame-tray.
ajay at activitycentral.com
Mon Mar 11 08:44:59 EDT 2013
On Mon, Mar 11, 2013 at 5:46 PM, Manuel Quiñones <manuq at laptop.org> wrote:
> Hi Ajay, thanks for keep working on this one.
> 2013/3/6 Ajay Garg <ajay at activitycentral.com>:
> > The solution has been build upon the "no-caching" solution provided by
> erikos at
> > http://bugs.sugarlabs.org/ticket/4419#comment:4
> > Theerafter, the cause of
> > is not taking "style.GRID_CELL_SIZE" into account, when calucating the
> alignments for the palettes.
> > I will have to thank manuq a great deal, for his comment
> > which helped me debug the real issue.
> > In particular, his observation that the "landscape"-mode-obscurity
> occurs only in one of the erikos' solutions;
> > while the "portrait-mode-obscurity" occurs only in both of erikos's
> > Finally, this patch provides the no-obscurity solution for all cases :)
> I see issues with your patch:
> 1. I can't bring the palettes of device icons (the ones at the bottom
> right of the frame) with the screen rotated in portrait mode.
> 2. after rotation I see the shutdown/reboot palette (icon on the right
> side of the frame) wrongly placed in landscape mode. See screenshot:
Hi Manuel; thanks for the testing.
Which build are you testing this on?
I will check it on the same build :)
> So it doesn't pass the TestCase:
> .. manuq ..
Activity Central: http://activitycentral.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Sugar-devel