[Sugar-devel] We have a problem: activity._shared_activity

[Gonzalo Odiard]

On Sat, Mar 2, 2013 at 7:01 AM, Agustin Zubiaga Sanchez
<aguz at sugarlabs.org>wrote:

> Gonzalo,
>
> Maybe would be good to create also the _shared_activity variable, with the
> purpose to let the activities continue working while the developers change
> _shared_actvity by shared_activity.
>
> What do you think?
>
>
I don't think so.
In first place, we should not use a private member in a class (denoted by
starting with "_").
Is a general norm. Other languages have better ways to protect this case,
but python only have this convention.
In second place, was deprecated for a long time. And is not a difficult
change to do at all.

Gonzalo


Regards,
> aguz
>
>
> 2013/2/27 Gonzalo Odiard <gonzalo at laptop.org>
>
>> After more testing, I found the problem is only with activities ported to
>> gtk3,
>> then the list of activities we need modify is reduced:
>>
>> distance: (activity.py)
>>>
>>> pippy: groupthink/sugar_tools.py and pippy/mainline/pippy_app.py)
>>>
>>> portfolio: (PortfolioActivity.py) (already solved in git)
>>>
>>> stopwatch: (activity.py)
>>>
>>> write: (AbiWordActivity.py)
>>>
>>> I have updated http://bugs.sugarlabs.org/ticket/4446.
>>>
>>>
>> Gonzalo
>>
>>
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130302/1ebde9af/attachment.html>