[Sugar-devel] Build broken, sugar

[Daniel Narvaez]

(Should be run inside an osbuild shell)


On 30 July 2013 12:25, Daniel Narvaez <dwnarvaez at gmail.com> wrote:

> I've seen from irc that you have the file... Please try to run a script
> like this (edit the path)
>
> import sys
>
> sys.path.append("/home/broot/sugar-build/build/out/install/share/sugar/extensions/")
> from cpsection.modemconfiguration.model import ServiceProvidersParser
>
> If it fails, please run it under strace and post the output. That should
> tell us where it's failing exactly.
>
>
>
> On 30 July 2013 11:08, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
>
>> I cannot reproduce on master either. Does
>> build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py
>> exist?
>>
>>
>> On 29 July 2013 22:21, Gonzalo Odiard <gonzalo at laptop.org> wrote:
>>
>>> Master.
>>>
>>> Full log: http://paste.fedoraproject.org/28781/29226137/
>>>
>>> Gonzalo
>>>
>>>
>>> On Mon, Jul 29, 2013 at 5:04 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>>
>>>> Weird. Master or chroot branch? It would be good to post the full trace.
>>>>
>>>>
>>>> On Monday, 29 July 2013, Gonzalo Odiard wrote:
>>>>
>>>>>  In my system, running osbuild check get:
>>>>>
>>>>> ImportError: No module named modemconfiguration.model
>>>>>
>>>>> in all the modemconfiguration tests.
>>>>>
>>>>> All is updated. Tried running, building, pulling and all.
>>>>>
>>>>> Gonzalo
>>>>>
>>>>>
>>>>> On Mon, Jul 29, 2013 at 9:44 AM, Miguel González <
>>>>> migonzalvar at activitycentral.com> wrote:
>>>>>
>>>>>> Good news! Thank you very much!
>>>>>>
>>>>>>
>>>>>> On Mon, Jul 29, 2013 at 2:41 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>>>>>
>>>>>> Fixed, gconf was not working at all in the chroot branch. Your tests
>>>>>> are all passing now!
>>>>>>
>>>>>>
>>>>>> On 29 July 2013 12:51, Miguel González <
>>>>>> migonzalvar at activitycentral.com> wrote:
>>>>>>
>>>>>> OK. Please, take into account I can mock GConf on every test but I
>>>>>> don't know if that makes sense.
>>>>>>
>>>>>>
>>>>>> On Mon, Jul 29, 2013 at 12:33 PM, Daniel Narvaez <dwnarvaez at gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>> Landed your pull request. Now it fails in gconf but I think that's a
>>>>>> sugar-build issue, I will take a look at that.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>>
>>>>>> On 29 July 2013 10:44, Miguel González <
>>>>>> migonzalvar at activitycentral.com> wrote:
>>>>>>
>>>>>>
>>>>>> Here is my patch: it checks if language code is not defined and use
>>>>>> default values in that case.
>>>>>>
>>>>>> [https://github.com/sugarlabs/sugar/pull/71]
>>>>>>
>>>>>> diff --git a/extensions/cpsection/modemconfiguration/model.py
>>>>>> b/extensions/cpsection/modemconfiguration/model.py
>>>>>> index c4e354d..a87cb03 100755
>>>>>> --- a/extensions/cpsection/modemconfiguration/model.py
>>>>>> +++ b/extensions/cpsection/modemconfiguration/model.py
>>>>>> @@ -119,10 +119,15 @@ class ServiceProvidersError(Exception):
>>>>>>
>>>>>>  def _get_name(el):
>>>>>>      language_code = locale.getdefaultlocale()[0]
>>>>>> -    lang = language_code.split('_')[0]
>>>>>> -    lang_ns_attr = '{http://www.w3.org/XML/1998/namespace}lang'
>>>>>>
>>>>>> -    tag = el.find('name[@%s="%s"]' % (lang_ns_attr, lang))
>>>>>> +    if language_code is None:
>>>>>> +        tag = None
>>>>>> +    else:
>>>>>> +        lang = language_code.split('_')[0]
>>>>>> +        lang_ns_attr = '{http://www.w3.org/XML/1998/namespace}lang'
>>>>>> +
>>>>>> +        tag = el.find('name[@%s="%s"]' % (lang_ns_attr, lang))
>>>>>> +
>>>>>>      if tag is None:
>>>>>>          tag = el.find('name')
>>>>>>
>>>>>> @@ -296,8 +301,11 @@ def __init__(self):
>>>>>>      def _guess_country_code(self):
>>>>>>          """Return country based on locale lang attribute."""
>>>>>>          language_code = locale.getdefaultlocale()[0]
>>>>>> -        lc_list = language_code.split('_')
>>>>>> -        country_code = lc_list[1].lower() if len(lc_list) >= 2 else
>>>>>> ''
>>>>>> +        if language_code is None:
>>>>>> +            country_code = ''
>>>>>> +        else:
>>>>>> +            lc_list = language_code.split('_')
>>>>>> +            country_code = lc_list[1].lower() if len(lc_list) >= 2
>>>>>> else ''
>>>>>>          return country_code
>>>>>>
>>>>>>      def _get_initials(self):
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Jul 29, 2013 at 10:00 AM, Daniel Narvaez <dwnarvaez at gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>> Hi Miguel,
>>>>>>
>>>>>> I think I misunderstood your analysis of the issue. sugar-build sets
>>>>>> LANG to C and I think that's something that should be supported... So I
>>>>>> think we should go with 2 in your list of alternatives.
>>>>>>
>>>>>>
>>>>>> On Monday, 29 July 2013, Miguel González wrote:
>>>>>>
>>>>>> Hi Daniel,
>>>>>>
>>>>>> Could you
>>>>>>
>>>>>> _______________________________________________
>>>>>>
>>>>>> Sugar-devel mailing list
>>>>>> Sugar-devel at lists.sugarlabs.org
>>>>>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Daniel Narvaez
>>>>
>>>>
>>>
>>
>>
>> --
>> Daniel Narvaez
>>
>
>
>
> --
> Daniel Narvaez
>



-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130730/959dfa0b/attachment-0001.html>