[Sugar-devel] Build broken, sugar

[Daniel Narvaez]

Miguel,

can you please send a patch for this as soon as possible? The build has
been broken for a few days now...


On 24 July 2013 08:59, Daniel Narvaez <dwnarvaez at gmail.com> wrote:

> Being shell code I think it's fine to assume the locale has been set. So
> I'd go for 1.
>
>
> On Wednesday, 24 July 2013, Miguel González wrote:
>
>> In this case in extensions/cpsection/modemconfiguration/model.py:299
>>
>> language_code = locale.getdefaultlocale()[0]
>>
>> returns None
>>
>> so one of the test fails:
>>
>> ======================================================================
>> ERROR: test_go_trough_all_combo_options
>> (test_modemconfiguration.ServiceProvidersTest)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>   File "/home/broot/sugar-build/sugar/tests/test_modemconfiguration.py",
>> line 128, in setUp
>>     self.db = ServiceProviders()
>>   File
>> "/home/broot/sugar-build/build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py",
>> line 274, in __init__
>>     country_code, provider_name, plan_idx = self._get_initials()
>>   File
>> "/home/broot/sugar-build/build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py",
>> line 309, in _get_initials
>>     country_code = self._guess_country_code()
>>   File
>> "/home/broot/sugar-build/build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py",
>> line 299, in _guess_country_code
>>     lc_list = language_code.split('_')
>> AttributeError: 'NoneType' object has no attribute 'split'
>>
>> ----------------------------------------------------------------------
>>
>> So:
>>
>> 1) Must set a locale in test environment?
>>
>> 2) Make code handle this scenario?
>>
>> 3) Both?
>>
>>
>>
>>
>> On Tue, Jul 23, 2013 at 11:56 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>
>> Still failing. Could that error be due to non functional gconf?
>>
>>
>> http://buildbot.sugarlabs.org/builders/quick/builds/46/steps/shell_2/logs/log
>>
>> I see a gconf error earlier in the log. I haven't yet looked at what is
>> going on with it. Maybe just a missing dependency.
>>
>>
>> On Tuesday, 23 July 2013, Miguel González wrote:
>>
>> https://github.com/sugarlabs/sugar-build/pull/22
>>
>> diff --git a/build/root.json b/build/root.json
>> index dd496e2..5a72922 100644
>> --- a/build/root.json
>> +++ b/build/root.json
>> @@ -67,6 +67,7 @@
>>              "gstreamer-plugins-espeak",
>>              "telepathy-salut",
>>              "telepathy-gabble",
>> +            "mobile-broadband-provider-info",
>>              "gnome-themes-standard",
>>              "xorg-x11-drv-evdev",
>>              "xorg-x11-drv-modesetting",
>>
>>
>>
>>
>> On Tue, Jul 23, 2013 at 12:53 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>
>> Yes!
>>
>>
>> On Tuesday, 23 July 2013, Miguel González wrote:
>>
>> It fails again [1] because does not find
>> /usr/share/mobile-broadband-provider-info/serviceproviders.xml.
>>
>> It seems this file is included in package mobile-broadband-provider-info
>> [2].
>>
>> May I add this package to on root.json sugar group too?
>>
>> [1]
>> http://buildbot.sugarlabs.org/builders/quick/builds/41/steps/shell_2/logs/stdio
>>
>>
>> [2]
>> https://apps.fedoraproject.org/packages/mobile-broadband-provider-info/
>>
>>
>> On Tue, Jul 23, 2013 at 9:52 AM, Miguel González <
>> migonzalvar at activitycentral.com> wrote:
>>
>> I guess is somethinks like this:
>>
>> From 47824c6e7622d0a59c4cf7960b97f63ece3d3623 Mon Sep 17 00:00:00 2001
>> From: Miguel Gonzalez <migonzalvar at activitycentral.com>
>> Date: Tue, 23 Jul 2013 09:45:56 +0200
>> Subject: [PATCH] Add python-mock dependency
>>
>> ---
>>  build/root.json | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/build/root.json b/build/root.json
>> index a826029..dd496e2 100644
>> --- a/build/root.json
>> +++ b/build/root.json
>> @@ -53,6 +53,7 @@
>>              "dbus-python",
>>              "python-telepathy",
>>              "python-dateutil",
>> +            "python-mock",
>>              "gtksourceview3",
>>              "dconf",
>>              "gsettings-desktop-schemas",
>> --
>> 1.8.1.6
>>
>>
>> https://github.com/sugarlabs/sugar-build/pull/21
>>
>>
>> On Tue, Jul 23, 2013 at 8:45 AM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>
>> We need to add python-mock to build/root.json, sugar group (chroot
>> branch).
>>
>> My fault for forgetting about it when approving the pull request, but I
>> can't fix it myself for a few days.
>>
>>
>> --
>> Daniel Narvaez
>>
>>
>>
>>
>> --
>> Miguel González
>> Activity Central: http://www.activitycentral.com
>>
>>
>>
>>
>
> --
> Daniel Narvaez
>
>


-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130728/c8abe4c7/attachment-0001.html>