[Sugar-devel] Multi selection in the Journal feature

[Martin Abente]

Hello Gonzalo!

Thank you very much for putting all of this patches together, and for
all the improvements! It seems to be a relatively big patch set, but
from what I can see it is nicely divided.

I will gladly help with the reviewing process and testing in general.

Saludos,
Tincho.


On Wed, Jul 17, 2013 at 5:42 PM, Gonzalo Odiard <gonzalo at laptop.org> wrote:
> A initial version to review of the feature is available to test and review.
>
> The pull requests are:
>
> sugar-datastore: https://github.com/sugarlabs/sugar-datastore/pull/2
> sugar-artwork: https://github.com/sugarlabs/sugar-artwork/pull/7
> sugar: https://github.com/sugarlabs/sugar/pull/62
>
> This work is based on previous implementations, but is different in many
> ways.
>
> In particular, the previous implementation had a performance problem,
> when the user wanted to select all the ellements in the journal.
> As the datastore is designed to return the data paginated,
> the journal needed to do several queries to get all the uids needed
> to create the list of selected items.
> This problem is solved adding a method to the datastore to get the uids
> belonging to a query. As the datastore get that information from the index,
> the query is really fast.
>
> Other visible change is the use of real checkboxes in the listview, instead
> of icons
> with a checkbox drawn. In a desktop, the checkbox is not displayed right,
> but in the xo is ok.
> Surely something we need solve in the theme.
>
> Another difference in behavior is now the user can interrupt a operation
> while is running.
> If you realize you started to delete all the objects in a pen drive, you can
> stop it,
> and at least part will be saved.
>
> Gonzalo
>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>