[Sugar-devel] [DESIGN] Feature "Enhanced support for 3G modems"
migonzalvar at activitycentral.com
Thu Jul 4 07:02:22 EDT 2013
On Thu, Jul 4, 2013 at 11:07 AM, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
> did we check what is parsing serviceproviders.xml in GNOME? It doesn't
> seem to be ModemManager so maybe it's not something we can reuse but I'd
> rather make sure before going with our own parser.
> AFAIK, the Service Provider Database is used by a wizard in
NetworkManager. The source code is in "network-manager-applet"  not in
"NetworkManager" or "ModemManager".
> On 2 July 2013 22:49, Miguel González <migonzalvar at activitycentral.com>wrote:
>> I've just send a pull request with the implementation of 3G database
>> support in control panel modem configuration section.
>> In this email, I'm attaching a screenshot to review UI design.
>> About the implementation, some highlights:
>> - There is a new config.py file with constants: file paths and GConf keys.
>> - It uses GConf keys to persistently store country, provider and plan
>> - In model.py a class controller retrieve data form XML and store
>> selections on GConf
>> - In the view.py, adds a new ScrolledWindow with an upper box for 3 combo
>> provider selection, a separator and a lower box with the previous entries
>> for network settings.
>> - When a plan is selected, network settings are changed using the same
>> I have some concerns:
>> - Is the GUI correct?
>> - File paths should be move to a template config.py.in file?
>> - I have kind of unitary tests for ServiceProviderDatabase class but I
>> don't know exactly where to put them. They use mock library to simulate
>> GConf calls.
>> - Is it necessary to write functional test for view? Is there information
>> about how to do it?
>> Thank you for your attention.
>> Miguel González
>> Activity Central: http://www.activitycentral.com
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
> Daniel Narvaez
Activity Central: http://www.activitycentral.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Sugar-devel