[Sugar-devel] [write PATCH] sl#4436: Making collaboration work again.

Manuel Quiñones manuq at laptop.org
Thu Feb 21 10:35:57 EST 2013


2013/2/21 Walter Bender <walter.bender at gmail.com>:
> I've had to make a similar change in my activities as well. (I guess I
> missed the patch go by when self._shared_activity became
> self.shared_actvity)  There is a also a method,
> self.get_shared_activity(), which might be better than directly
> referencing the instance variable. I suppose it is a style issue.

Thanks both Ajay and Walter for looking at this.

Yes, git log says to me that the usage of _shared_activity was marked
as deprecated in the code for a long time, and get_shared_activity was
the recommended form.  This deprecation was removed in commit 70cee447
of toolkit-gtk3 in January 2012, and the API change was stated in 0.96
release notes:

http://wiki.sugarlabs.org/go/0.96/Notes#API.

We should check if other activities are still using it.  Help welcome.

-- 
.. manuq ..


More information about the Sugar-devel mailing list