[Sugar-devel] [web-activity] functional tests and env.isStandalone's current implementation

[Daniel Narvaez]

Ouch! Now I see, I had no thought of this issue... Good find!

What about using the user agent in isStandalone instead of the protocol? We
can make the web activity and the sugar-web-test use two different,
recognizable user agents.

On Friday, 20 December 2013, Rogelio Mita wrote:

>
> 2013/12/19 Daniel Narvaez <dwnarvaez at gmail.com <javascript:_e({}, 'cvml',
> 'dwnarvaez at gmail.com');>>
>
>> On 19 December 2013 21:48, Rogelio Mita <rogeliomita at activitycentral.com<javascript:_e({}, 'cvml', 'rogeliomita at activitycentral.com');>
>> > wrote:
>>
>>> All sugar-web's tests are running into activityweb container, using
>>> sugar-web-test activity, all url requests which they do, have "http"
>>> scheme, and our current implementation of isStandanlone makes check on the
>>> current scheme of the request given (isStandalone method<https://github.com/sugarlabs/sugar-web/blob/master/env.js#L40>),
>>> then...
>>>
>>
>> You mean "activity" scheme right?
>>
>
> yes! When run karma tests, the scheme is "http", is not "activity"
>
>
>>
>>
>>>  functional tests believe are in standalone mode when they use
>>> isStandalone method. Mocking this method on unit tests is ok... but we
>>> think is not good idea mocking this on functional tests... or yes???
>>>
>>
>> Can you explain what you mean with functional tests? (perhaps just
>> lacking terminology on my side).
>>
>
> I mean integration tests<http://en.wikipedia.org/wiki/Integration_testing>
>  =)
>
>
> --
> Roger
>
> Activity Central <http://activitycentral.com/>
>


-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20131220/7609e878/attachment-0001.html>