[Sugar-devel] Frequent buildbot check failures in sugar-web

Rogelio Mita rogeliomita at activitycentral.com
Fri Dec 13 15:24:15 EST 2013


2013/12/13 Code Raguet <iraguet at activitycentral.com>

> Only on the first save().
>> Using getEnv().defaultTimeoutInterval = something we could increase the
>> timeout for all the datastore tests or even for all the tests. I'm worried
>> it would get a bit annoying for development to always have a big timeout...
>
>
> Perhaps we should do as in env.js...
> Adding anachronistic unit-tests (tests that check the logic in isolation,
> mocking and stubbing the external services and deps) that would run faster,
> hence lighting the development process.
>

+1


> Also, moving those heavier tests (whose check through the actual
> implementation) to another file that, developers would run after a long
> round of development (before pushing, for example) or just leaving that job
> to buildbot.
>
Therefore, we would have the benefit that the current tests give (keeping
> big timeouts, may be) without delaying developers.
>

+1. This point is an advantage to run tests on any basic browser if is
necessary in any time.

Then we can do:
- separate this functional tests on another file and run it on full-master
maybe for first approach?
- solve on temporary way using increasing timeout (if we see that this
approach works...)
- doing unit tests for datastore.js

I think... now it works (always assuming that higher time, we reduce or
avoid completely the probability of failure of the tests, to see...), just
that it is sometimes a bit slow datastore labor, we should take note to
solve in the future, but inevitably we should have unit tests here and be
sure that the functional tests on full-master run well, even a little slow
the running time of the tests.


>
>
> On Fri, Dec 13, 2013 at 2:48 PM, Rogelio Mita <
> rogeliomita at activitycentral.com> wrote:
>
>>
>> 2013/12/12 Daniel Narvaez <dwnarvaez at gmail.com>
>>
>>> Only on the first save().
>>>
>>> Using *getEnv*().*defaultTimeoutInterval* = something we could increase the timeout for all the datastore tests or even for all the tests. I'm worried it would get a bit annoying for development to always have a big timeout... An alternative could be to have a speficic test at the top to get through this, with a title explaining what it's doing, so that we wouldn't keep breaking it. I dunno... thoughts? Patches welcome too, if anyone has more time than me!
>>>
>>>
>> oh!, now we have a lot of information about, let me collect and
>> understand better the situation before send a more complete answer
>>
>>
>> --
>> Roger
>>
>> Activity Central <http://activitycentral.com/>
>>
>
>


-- 
Roger

Activity Central <http://activitycentral.com/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20131213/0f9f06f9/attachment-0001.html>


More information about the Sugar-devel mailing list