[Sugar-devel] [DESIGN] Frame icon to take a screenshot

[James Cameron]

On Tue, Dec 03, 2013 at 09:25:46AM -0200, Ignacio Rodríguez wrote:
> Before taking screenshot the frame hides automatically
> 
> +    def _take_screenshot(self, frame_):
> +        while frame_.is_visible():
> +            return True

The "while" should be "if".  (It is not a busy loop, the while loop
will be abandoned in the first iteration).

> +
> +        take_screenshot()
> +        frame_.show()

There should be a "return False", for readability and comprehension.

> After taking screenshot the frame show automatically
> 
> > is it using any kind of cues to know when the screenshot was taken?
> 
> No, I don't use signals! take_screenshot() never fails (Same code of Alt+1
> shortcut)
> 
> Sorry for my bad english :(
> 
> Grettings,
> Ignacio Rodríguez

> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel


-- 
James Cameron
http://quozl.linux.org.au/